Skip to content

Conversation

@ltouati
Copy link
Contributor

@ltouati ltouati commented Dec 14, 2025

The Fix:

Added Position Caching: Added fLastX and fLastY to the VMWareMouseFilter class to store the last known raw absolute coordinates from VMWare.
Updated Filter Logic:
When new data is available (numWords > 0), we update fLastX/fLastY with the new raw coordinates.
When no new data is available (numWords == 0):
B_MOUSE_MOVED events are still skipped (as before).
B_MOUSE_DOWN and B_MOUSE_UP events are preserved. Crucially, I now use the cached fLastX/fLastY (if available) to update the event's location.
This ensures that even if you click without moving the mouse (which often results in "no new data" from the VMWare backdoor), the click event is dispatched with the correct absolute coordinates that match where the cursor is visually drawn. This prevents the click from happening at a stale or incorrect location.

The VMWare mouse driver should now handle clicks reliably.

@OscarL OscarL mentioned this pull request Dec 14, 2025
@OscarL
Copy link
Contributor

OscarL commented Dec 15, 2025

Can't comment on the code change/fix, but I think it would be good if the removal of vmwmouse was either split into a separate PR, or at the very least addressed on the commit message (with a mention of issue #10).

@ltouati
Copy link
Contributor Author

ltouati commented Dec 21, 2025

Hi @OscarL I'm happy to split the PR into 2 but we agree that having 2 vmware_mouse is not usefull . Let me know what you think.

@OscarL
Copy link
Contributor

OscarL commented Dec 21, 2025

A separate PR for removing the old and unused vmwouse (with commit message referencing issue #10 and/or the commits where vmware_mouse got merged) is what I would do.

Speaking of thing that I would do... I'll go ahead and open a PR for removing the enhanced_backdoor code, as you did on #47, given that the latter might not get merged (and didn't properly explained the files removal).


BTW, do you have step by step instructions on how to trigger the bug you're trying to fix on this PR?

Asking because I'm not sure I had noticied it, and not being able to reproduce it, can't properly check the fix for it :-D.

Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants