Skip to content

Conversation

@ltouati
Copy link
Contributor

@ltouati ltouati commented Dec 14, 2025

Sync host time with guest one to prevent issues with the vmware fs for example

@OscarL
Copy link
Contributor

OscarL commented Dec 14, 2025

Please explain how/why adding a timesync daemon ends up deleting totally unrelated files. Similarly on #45, there VMWMouseFilter.{h,cpp} and even a Makefile get suspiciously deleted. (Edit: removal of vmvmouse makes sense, IMO, but not without even a mention on the PR or commit message)

These PRs smell of poorly reviewed AI generated code could use better commit messages (and/or splitting of unrelated changes).

#define CLIPBOARD_POLL 'clPo'
#define CLOCK_POLL 'ckPo'
#define SHRINK_DISKS 'shDk'
#define TIME_SYNC_SHARING 'time'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not be using only letters of the first word, collisions would be too easy

@waddlesplash
Copy link
Member

Isn't this already done by vmware_tray? I am pretty sure it is?

@OscarL
Copy link
Contributor

OscarL commented Dec 15, 2025

Isn't this already done by vmware_tray? I am pretty sure it is?

vmware_tray uses a BMessageRunner to trigger a CLOCK_POLL event (which ends up calling set_real_time_clock() with the value returned by backdoor.GetHostClock().

@ltouati
Copy link
Contributor Author

ltouati commented Dec 21, 2025

Hey Team, thx a lot for the feedback. I did not notice that vmware_tray did have this function. Please close the PR if you think it's not usefull

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants