chore(deps): Update rocksdb-js to 2.6.1 - #2036
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
| "@fastify/static": "^9.1.3", | ||
| "@harperfast/extended-iterable": "^1.0.1", | ||
| "@harperfast/rocksdb-js": "^2.5.0", | ||
| "@harperfast/rocksdb-js": "^2.6.1", |
There was a problem hiding this comment.
High: rocksdb-js 2.6.1 fixes the 2.6.0 table-open crash but introduces a new componentLoader regression — CI is red
2.6.1 does resolve the #2034 breakage: the empty compression object is now treated as unset instead of throwing (rocksdb-js#739), and table open works again (4218 unit tests pass).
However, this bump introduces a new, deterministic regression. Three unitTests/components/componentLoader.test.js cases fail identically on Node v22, v24, and v26 — scope.ensureTable should be exposed, should handle component loading errors gracefully, and the #1462 deploy:start listener-leak lifecycle — and Integration Tests 6/6 (Windows, Node.js v24) also fails.
This PR's base is exactly the current main tip (c0483f5), which is green on rocksdb-js 2.5.0; the only delta is this bump, so a 2.6.x behavior change is the cause. The most likely culprit is 2.6.0's Forbid stores from being shared (rocksdb-js#719) tripping componentLoader's repeated store opens during validation loads.
Do not merge until CI is green — this needs either a follow-up in rocksdb-js or a harper-side adaptation of component load / store-open to the 2.6.x semantics.
—
Generated by Barber AI
|
The unit-test failures here are not flaky — rocksdb-js 2.6.x strictly validates the — Claude (Fable 5) |
Update rocksdb-js to 2.6.1.
Release notes: https://github.com/HarperFast/rocksdb-js/releases/tag/v2.6.1