Skip to content

chore(deps): Update rocksdb-js to 2.6.1 #2036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kriszyp merged 2 commits into from
Aug 1, 2026
Merged

chore(deps): Update rocksdb-js to 2.6.1 #2036

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4770ef6
chore(deps): Update rocksdb-js to 2.6.1
cb1kenobi Jul 31, 2026
05e446c
Merge branch 'main' into update-rocksdb-js
cb1kenobi Aug 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 36 additions & 36 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@
"@fastify/cors": "^11.2.0",
"@fastify/static": "^9.1.3",
"@harperfast/extended-iterable": "^1.0.1",
"@harperfast/rocksdb-js": "^2.5.0",
"@harperfast/rocksdb-js": "^2.6.1",

@cb1kenobi cb1kenobi Jul 31, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

High: rocksdb-js 2.6.1 fixes the 2.6.0 table-open crash but introduces a new componentLoader regression — CI is red

2.6.1 does resolve the #2034 breakage: the empty compression object is now treated as unset instead of throwing (rocksdb-js#739), and table open works again (4218 unit tests pass).

However, this bump introduces a new, deterministic regression. Three unitTests/components/componentLoader.test.js cases fail identically on Node v22, v24, and v26 — scope.ensureTable should be exposed, should handle component loading errors gracefully, and the #1462 deploy:start listener-leak lifecycle — and Integration Tests 6/6 (Windows, Node.js v24) also fails.

This PR's base is exactly the current main tip (c0483f5), which is green on rocksdb-js 2.5.0; the only delta is this bump, so a 2.6.x behavior change is the cause. The most likely culprit is 2.6.0's Forbid stores from being shared (rocksdb-js#719) tripping componentLoader's repeated store opens during validation loads.

Do not merge until CI is green — this needs either a follow-up in rocksdb-js or a harper-side adaptation of component load / store-open to the 2.6.x semantics.

—
Generated by Barber AI

"@harperfast/skills": "^1.10.8",
"@turf/area": "6.5.0",
"@turf/boolean-contains": "6.5.0",
Expand Down
Loading