Skip to content

Conversation

@ChrisNolan
Copy link

@ChrisNolan ChrisNolan commented Jan 3, 2026

  • Implemented a retry mechanism for composition stats retrieval in case of errors.
  • Added a "Retry" button in the UI to allow users to manually retry fetching stats.
  • Enhanced error logging for better debugging of composition stats issues.

fixes issue #4685

NOTE: I haven't signed the CLA yet -- the Dev Discord link in the contributing file has an invalid invite 🤷

I'll drop an email.

@beheh
Copy link
Contributor

beheh commented Jan 8, 2026

Hi there, thanks for your PR! All contributions to HearthSim require a signed CLA. I've sent you an invite to the repository, please follow the instructions there. If you've already signed the CLA, please let us know.

Once that's done and the CLA has been merged, we'll try to get this merged here as soon as possible.

I'll get the broken Discord link figured out, thanks for highlighting that!

@ChrisNolan ChrisNolan force-pushed the feat/retry-connection-failures branch from 40b1d0b to e263fad Compare January 9, 2026 23:57
@ChrisNolan
Copy link
Author

Thanks beheh. Done the CLA now. Cheers.

Oh, I messed up the rebase so my 2 commits because 18 replaying a bunch so I force pushed another one with just my changes but put them into a single commit without my notes. hope that's ok.

@ChrisNolan
Copy link
Author

Hi @beheh just checking in. Was there any issue with my CLA or my PR? Let me know if I can do anything differently.

@beheh
Copy link
Contributor

beheh commented Jan 21, 2026

Sorry for the delay - I've merged the CLA. I'll have my colleague follow up on this PR!

- Implemented a retry mechanism for composition stats retrieval in case of errors.
- Added a "Retry" button in the UI to allow users to manually retry fetching stats.
- Enhanced error logging for better debugging of composition stats issues.
- Implemented a retry mechanism for composition stats retrieval in case of errors.
- Added a "Retry" button in the UI to allow users to manually retry fetching stats.
- Enhanced error logging for better debugging of composition stats issues.
@ChrisNolan ChrisNolan force-pushed the feat/retry-connection-failures branch from e263fad to 84927d7 Compare February 1, 2026 18:24
@ChrisNolan
Copy link
Author

FYI I've rebased the PR. Let me know if there is anything you'd like changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants