-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: add retry functionality for comp stats errors #4686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: add retry functionality for comp stats errors #4686
Conversation
|
Hi there, thanks for your PR! All contributions to HearthSim require a signed CLA. I've sent you an invite to the repository, please follow the instructions there. If you've already signed the CLA, please let us know. Once that's done and the CLA has been merged, we'll try to get this merged here as soon as possible. I'll get the broken Discord link figured out, thanks for highlighting that! |
40b1d0b to
e263fad
Compare
|
Thanks beheh. Done the CLA now. Cheers. Oh, I messed up the rebase so my 2 commits because 18 replaying a bunch so I force pushed another one with just my changes but put them into a single commit without my notes. hope that's ok. |
|
Hi @beheh just checking in. Was there any issue with my CLA or my PR? Let me know if I can do anything differently. |
|
Sorry for the delay - I've merged the CLA. I'll have my colleague follow up on this PR! |
- Implemented a retry mechanism for composition stats retrieval in case of errors. - Added a "Retry" button in the UI to allow users to manually retry fetching stats. - Enhanced error logging for better debugging of composition stats issues.
- Implemented a retry mechanism for composition stats retrieval in case of errors. - Added a "Retry" button in the UI to allow users to manually retry fetching stats. - Enhanced error logging for better debugging of composition stats issues.
e263fad to
84927d7
Compare
|
FYI I've rebased the PR. Let me know if there is anything you'd like changed. |
fixes issue #4685
NOTE: I haven't signed the CLA yet -- the Dev Discord link in the contributing file has an invalid invite 🤷
I'll drop an email.