Fix ILU binding API mismatch#107
Merged
Merged
Conversation
yhmtsai
approved these changes
May 12, 2026
yhmtsai
requested changes
May 12, 2026
yhmtsai
left a comment
yhmtsai
left a comment
Collaborator
There was a problem hiding this comment.
I think we can add the macro here now
yhmtsai
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the ILU preconditioner binding to match the updated Ginkgo API.
The previous binding used the old
gko::preconditioner::Ilutemplate interface with explicit lower and upper triangular solver types. The current Ginkgo API expects the template parameters in the form:Type of change
Checklist