Skip to content

Fix ILU binding API mismatch#107

Open
2002kaihui wants to merge 3 commits into
mainfrom
fix/ilu-gko-api-mismatch
Open

Fix ILU binding API mismatch#107
2002kaihui wants to merge 3 commits into
mainfrom
fix/ilu-gko-api-mismatch

Conversation

@2002kaihui
Copy link
Copy Markdown
Collaborator

Description

Fixes the ILU preconditioner binding to match the updated Ginkgo API.

The previous binding used the old gko::preconditioner::Ilu template interface with explicit lower and upper triangular solver types. The current Ginkgo API expects the template parameters in the form:

gko::preconditioner::Ilu<ValueType, ReverseApply, IndexType>

Type of change

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing tests pass locally with my changes

Copy link
Copy Markdown
Collaborator

@yhmtsai yhmtsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can add the macro here now

gko::preconditioner::Ilu<gko::solver::LowerTrs<ValueType, IndexType>,
gko::solver::UpperTrs<ValueType, IndexType>,
false>;
using Ilu = gko::preconditioner::Ilu<ValueType, false, IndexType>;
Copy link
Copy Markdown
Collaborator

@yhmtsai yhmtsai May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can also use macro to support both version

#if GKO_VERSION_MAJOR == 1
// use the first part
#else
// use the latest part
#endif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants