Skip to content

Fix ILU binding API mismatch #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2002kaihui merged 4 commits into from
May 18, 2026
Merged

Fix ILU binding API mismatch #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
77ccbd7
Fix ILU binding API and repr type
2002kaihui May 1, 2026
971e9bc
Merge pull request #106 from 2002kaihui/fix/ilu-gko-api-mismatch
greole May 5, 2026
ca31527
Fix ILU binding formatting and changelog
2002kaihui May 7, 2026
31676a4
fix: support both ILU APIs with Ginkgo version macro
2002kaihui May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# Version 0.1.0 (unreleased)
- Fix ILU preconditioner binding for the updated Ginkgo API [#107](https://github.com/Helmholtz-AI-Energy/pyGinkgo/pull/107)
- Add CuPy interoperability for zero-copy GPU data exchange via `__cuda_array_interface__`
- Make it pip installable [#86](https://github.com/Helmholtz-AI-Energy/pyGinkgo/pull/86)
- Fix circular import issue by renaming `types.py` to `gko_types.py` [#85](https://github.com/Helmholtz-AI-Energy/pyGinkgo/pull/85)
Expand Down
10 changes: 7 additions & 3 deletions src/cpp_bindings/preconditioner/ilu.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,14 @@
#include "../utils.hpp"

template <typename ValueType, typename IndexType>
#if GKO_VERSION_MAJOR == 1
using Ilu =
gko::preconditioner::Ilu<gko::solver::LowerTrs<ValueType, IndexType>,
gko::solver::UpperTrs<ValueType, IndexType>,
false>;
gko::solver::UpperTrs<ValueType, IndexType>, false,
IndexType>;
#else
using Ilu = gko::preconditioner::Ilu<ValueType, false, IndexType>;
Comment thread
yhmtsai marked this conversation as resolved.
#endif

template <typename ValueType, typename IndexType>
void init_ilu(py::module_ &module_preconditioner, const std::string value_type,
Expand All @@ -36,7 +40,7 @@ void init_ilu(py::module_ &module_preconditioner, const std::string value_type,
return gko::share(ilu_pre_factory->generate(par_ilu));
}))
.def("__repr__",
[=](const gko::solver::Gmres<ValueType> &o) { return repr_str; });
[=](const Ilu<ValueType, IndexType> &o) { return repr_str; });
}

void init_ilu_all_types(py::module_ &module_preconditioner)
Expand Down
Loading