fix: nil-check start_time element in _set_recheck (#1174)#1220
Merged
HenriWahl merged 1 commit intoMay 3, 2026
Merged
Conversation
Return a clear Result error when the start_time element is missing (insufficient role permissions) instead of crashing with AttributeError on NoneType.attrs. Signed-off-by: SAY-5 <say.apm35@gmail.com>
HenriWahl
pushed a commit
that referenced
this pull request
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1174.
When a Zabbix 7 (or any Nagios-class) user lacks permission to schedule rechecks,
result.result.find(attrs={'name': 'start_time'})returnsNoneand.attrsraisesAttributeError. Now the result is nil-checked and a clearResulterror is returned instead of crashing.