Skip to content

fix: nil-check start_time element in _set_recheck (#1174) #1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HenriWahl merged 1 commit into from
May 3, 2026
Merged

fix: nil-check start_time element in _set_recheck (#1174) #1220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Nagstamon/servers/Generic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,7 +449,12 @@ def _set_recheck(self, host, service):
# get start time from Nagios as HTML to use same timezone setting like the locally installed Nagios
result = self.fetch_url(
self.monitor_cgi_url + '/cmd.cgi?' + urllib.parse.urlencode({'cmd_typ': '96', 'host': host}))
self.start_time = dict(result.result.find(attrs={'name': 'start_time'}).attrs)['value']
start_time_element = result.result.find(attrs={'name': 'start_time'})
if start_time_element is None:
# element missing usually means the user lacks permission to schedule rechecks
return Result(result='Recheck not permitted: missing start_time element (insufficient role permissions?)',
error='start_time element not found')
self.start_time = dict(start_time_element.attrs)['value']
# decision about host or service - they have different URLs
if service == '':
# host
Expand Down
Loading