fs/memory-provider

[XiaochenCui]

fix #1407

[XiaochenCui]

hey @KernelDeimos
this PR has passed apitest and is ready for review/merge

[XiaochenCui]

Now you have to mount /tmp in config.json:

        "mountpoint": {
            "mountpoints": {
                "/": {
                    "mounter": "puterfs"
                },
                "/tmp": {
                    "mounter": "memoryfs"
                }
            }
        }

This PR has passed apitest and manual teste:

await puter.fs.stat('/tmp')
await puter.fs.mkdir('/tmp/a/b/c', { createMissingParents: true })
await puter.fs.stat('/tmp/a')
await puter.fs.mkdir('/tmp/foo')

[XiaochenCui]

all tests passed, it's ready for review & merge

repo: XiaochenCui/puter
ref: fs/memoryfs
start: 2025-08-09T12:25:55
duration: 29.43s

┌────────────────────────────────────────────┬────────┬────────┬───────┐
│ (index)                                    │ passed │ failed │ total │
├────────────────────────────────────────────┼────────┼────────┼───────┤
│ Cartesian Test for /write - puterfs        │ 24     │ 0      │ 24    │
│ Cartesian Test for /move - puterfs         │ 48     │ 0      │ 48    │
│ Cartesian Test for /copy - puterfs         │ 144    │ 0      │ 144   │
│ write and read - puterfs                   │ 6      │ 0      │ 6     │
│ move - puterfs                             │ 4      │ 0      │ 4     │
│ stat - puterfs                             │ 157    │ 0      │ 157   │
│ readdir - puterfs                          │ 115    │ 0      │ 115   │
│ mkdir - puterfs                            │ 23     │ 0      │ 23    │
│ batch - puterfs                            │ 4      │ 0      │ 4     │
│ delete - puterfs                           │ 7      │ 0      │ 7     │
│ single write for trace and span - puterfs  │ 0      │ 0      │ 0     │
│ Cartesian Test for /write - memoryfs       │ 24     │ 0      │ 24    │
│ Cartesian Test for /move - memoryfs        │ 48     │ 0      │ 48    │
│ Cartesian Test for /copy - memoryfs        │ 144    │ 0      │ 144   │
│ write and read - memoryfs                  │ 6      │ 0      │ 6     │
│ move - memoryfs                            │ 4      │ 0      │ 4     │
│ stat - memoryfs                            │ 157    │ 0      │ 157   │
│ readdir - memoryfs                         │ 115    │ 0      │ 115   │
│ mkdir - memoryfs                           │ 23     │ 0      │ 23    │
│ batch - memoryfs                           │ 4      │ 0      │ 4     │
│ delete - memoryfs                          │ 7      │ 0      │ 7     │
│ single write for trace and span - memoryfs │ 0      │ 0      │ 0     │
└────────────────────────────────────────────┴────────┴────────┴───────┘

[KernelDeimos]

Why was this changed to let? I don't see any assignment to path below this line.

[XiaochenCui]

yeah, it should be const

[KernelDeimos]

I don't agree with this variable name change. I think dir is too vague. top_parent wasn't great either though; perhaps "immediate_parent" would have been better.

[XiaochenCui]

The dir is only the immediate_parent from the caller’s perspective. From this function's perspective, it knows nothing about it (and doesn’t seem to care) 😄 .

The funny thing is, this function can create any directory it’s given, since it uses the super-charged MkTree API:

puter/src/backend/src/filesystem/hl_operations/hl_mkdir.js

Lines 490 to 494 in 1e720a7

	const tree_op = new MkTree();
	await tree_op.run({
	parent: await fs.node(new RootNodeSelector()),
	tree: [path],
	});

[XiaochenCui]

but I do agree to rename top_parent -> immediate_parent in the mkdir

(another option is use parent for immediate-parent and ancestors for non-immediate-parent)

[KernelDeimos]

Is this still required or was this for testing purposes?

[XiaochenCui]

It's a personal choice and used in doc comments and type check:

        // type check
        if ( ! (selector instanceof NodeSelector) ) {
            throw new Error('Invalid selector type');
        }

    /**
     * Check if a given node exists.
     *
     * @param {Object} param
     * @param {NodeSelector} param.selector - The selector used for checking.
     * @returns {Promise<boolean>} - True if the node exists, false otherwise.
     */