chore(deps): bump schemaui from 0.12.3 to 0.12.4 - #5695
Conversation
|
Thanks @dependabot[bot] for taking the time to contribute. This repository is observing a maintainer-managed PR intake gate in dry-run mode, so this pull request is staying open. This note helps maintainers prepare the allowlist before any enforcement is considered. Please read |
There was a problem hiding this comment.
Codewhale review
This Dependabot PR updates the schemaui crate from 0.12.3 to 0.12.4 in Cargo.lock. The upstream release is a patch-level bug fix that omits null-valued objects in TOML preview output, plus documentation/CI housekeeping. No new dependencies are introduced and no code changes are included in the PR.
Findings
- [INFO] Only Cargo.lock was updated; confirm manifest version constraint (
Cargo.toml)
The diff does not include a Cargo.toml change. Ifschemauiis a direct dependency, verify that its declared version requirement still permits 0.12.4 (e.g."0.12"or"0.12.3"with caret semantics). If the project intentionally pins the exact version, Cargo.toml should also be updated. - [WARNING] TOML preview output may change
schemaui 0.12.4 includes a bug fix that omits object nulls in TOML preview. If CodeWhale uses schemaui's preview functionality, rendered output may change for configurations that previously included null-valued objects. Existing snapshot or golden-file tests may need to be updated, and the new behavior should be verified as intended.
Suggestions
- Run the full test suite, especially any tests covering schemaui or TOML preview snapshots, before merging this dependency bump.
Cargo.toml— Ifschemauiis a direct dependency, consider making the minimum version explicit by updating the requirement to"0.12.4"or"^0.12.4".- Add or update a regression test for TOML preview with null object fields to document the new omission behavior and prevent accidental regressions.
Assessment
Low-risk patch-level dependency bump. No blocking issues found, but the TOML preview behavior change should be verified against existing tests before merging.
Advisory review by Codewhale (codewhale review --pr 5695 --post, head c0139b0565a8a5c1d6beddb6db317853c58d4596). Line-specific findings are also posted as inline review comments. CODEOWNERS approval still governs merge.
|
@dependabot rebase |
c0139b0 to
6c3ccbd
Compare
|
@dependabot rebase |
6c3ccbd to
9f3fca9
Compare
|
@dependabot rebase Maintainer note: both reds on this PR (Test macos-latest and Test windows-latest, run 33270725867) are the six |
Bumps [schemaui](https://github.com/yuniqueunic/schemaui) from 0.12.3 to 0.12.4. - [Release notes](https://github.com/yuniqueunic/schemaui/releases) - [Changelog](https://github.com/YuniqueUnic/schemaui/blob/main/CHANGELOG.md) - [Commits](YuniqueUnic/schemaui@schemaui-v0.12.3...schemaui-v0.12.4) --- updated-dependencies: - dependency-name: schemaui dependency-version: 0.12.4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
9f3fca9 to
3c5e1b0
Compare
Bumps schemaui from 0.12.3 to 0.12.4.
Release notes
Sourced from schemaui's releases.
Changelog
Sourced from schemaui's changelog.
Commits
cdcc7bcchore: sync README and CLI dependency to 0.12.4c29d79bchore: release4b4c71bMerge pull request #163 from YuniqueUnic/fix/toml-preview-nulldb4aa98fix: omit object nulls in TOML preview6023bd6build(deps): bump taiki-e/install-action from 2.82.5 to 2.85.22e5fb59build(deps): bump taiki-e/setup-cross-toolchain-action5a4f704build(deps): bump actions-rust-lang/setup-rust-toolchain8a23e28docs: clarify CLI/Web surfaces and add Web UI screenshotf470ba6chore: sync package manager manifests for schemaui-cli-v0.7.5