Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stashapp 0.27.2 (new formula) #203821

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

not-me-for-sure
Copy link

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue nodejs Node or npm use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core ffmpeg FFMPEG use is a significant feature of the PR or issue labels Jan 10, 2025
Copy link
Contributor

github-actions bot commented Feb 1, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Feb 1, 2025
depends_on "ffmpeg"

def install
ENV.deparallelize
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What goes wrong when building in parallel?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The makefile is not written to support parallel compilation. It fails when enabled.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@not-me-for-sure Please report this to the upstream project as an issue and add a link to that issue here. We consider requiring no parallelisation as a bug as it slows things down a lot.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@not-me-for-sure please add a Ruby comment in the formula providing context and linking to to this issue, thanks!

Comment on lines +16 to +17
bin.install "stash"
bin.install "phasher"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no make install?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately there is not :/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@not-me-for-sure Similarly: please request one from upstream and add a link to the issue.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@not-me-for-sure please add a Ruby comment in the formula providing context and linking to to this issue, thanks!

@github-actions github-actions bot removed the stale No recent activity label Feb 3, 2025
Fix language

Co-authored-by: Mike McQuaid <[email protected]>
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Feb 3, 2025
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the PR! Looking good, almost there!

Provide comments about the changes requested in upstream project.
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@not-me-for-sure
Copy link
Author

@MikeMcQuaid Hi, it seems that the CI failed due to a network failure. Would you mind re-spinning it?

Thanks!

  go: downloading golang.org/x/sync v0.7.0
  exit status 1
  cmd/stash/main.go:1: running "go": exit status 1

@not-me-for-sure
Copy link
Author

Hmm, weird. Same error again, but the only change from the last passing state was adding a comment.

@MikeMcQuaid
Copy link
Member

Something may have changed upstream in Go-land.

@not-me-for-sure
Copy link
Author

Can't repro locally though. It's building fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosquash Automatically squash pull request commits according to Homebrew style. ffmpeg FFMPEG use is a significant feature of the PR or issue go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core nodejs Node or npm use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants