Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stashapp 0.27.2 (new formula) #203821

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions Formula/s/stashapp.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
class Stashapp < Formula
desc "Organizer for your explicit images"
homepage "https://stashapp.cc"
url "https://github.com/stashapp/stash/archive/refs/tags/v0.27.2.tar.gz"
sha256 "23402a61329d3c57f0d161e469b07a14a7672f799ff9d97bf082c1b67ace2dea"
license "AGPL-3.0-only"

depends_on "go" => :build
depends_on "node" => :build
depends_on "yarn" => :build
depends_on "ffmpeg"

def install
ENV.deparallelize
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What goes wrong when building in parallel?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The makefile is not written to support parallel compilation. It fails when enabled.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@not-me-for-sure Please report this to the upstream project as an issue and add a link to that issue here. We consider requiring no parallelisation as a bug as it slows things down a lot.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@not-me-for-sure please add a Ruby comment in the formula providing context and linking to to this issue, thanks!

system "make", "release"
bin.install "stash"
bin.install "phasher"
Comment on lines +20 to +21
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no make install?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately there is not :/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@not-me-for-sure Similarly: please request one from upstream and add a link to the issue.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@not-me-for-sure please add a Ruby comment in the formula providing context and linking to to this issue, thanks!

end

service do
run [opt_bin/"stash", "--nobrowser"]
keep_alive true
end

test do
port = free_port
pid = spawn bin/"stash", "--port", port.to_s
sleep 2

begin
response = shell_output("curl -s http://127.0.0.1:#{port}")
assert_match "<title>Stash</title>", response
ensure
Process.kill("TERM", pid)
Process.wait(pid)
end
end
end
Loading