-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stashapp 0.27.2 (new formula) #203821
base: master
Are you sure you want to change the base?
stashapp 0.27.2 (new formula) #203821
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
class Stashapp < Formula | ||
desc "Organizer for your explicit images" | ||
homepage "https://stashapp.cc" | ||
url "https://github.com/stashapp/stash/archive/refs/tags/v0.27.2.tar.gz" | ||
sha256 "23402a61329d3c57f0d161e469b07a14a7672f799ff9d97bf082c1b67ace2dea" | ||
license "AGPL-3.0-only" | ||
|
||
depends_on "go" => :build | ||
depends_on "node" => :build | ||
depends_on "yarn" => :build | ||
depends_on "ffmpeg" | ||
|
||
def install | ||
ENV.deparallelize | ||
system "make", "release" | ||
bin.install "stash" | ||
bin.install "phasher" | ||
Comment on lines
+20
to
+21
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there no There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unfortunately there is not :/ There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @not-me-for-sure Similarly: please request one from upstream and add a link to the issue. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @not-me-for-sure please add a Ruby comment in the formula providing context and linking to to this issue, thanks! |
||
end | ||
|
||
service do | ||
run [opt_bin/"stash", "--nobrowser"] | ||
keep_alive true | ||
end | ||
|
||
test do | ||
port = free_port | ||
pid = spawn bin/"stash", "--port", port.to_s | ||
sleep 2 | ||
|
||
begin | ||
response = shell_output("curl -s http://127.0.0.1:#{port}") | ||
assert_match "<title>Stash</title>", response | ||
ensure | ||
Process.kill("TERM", pid) | ||
Process.wait(pid) | ||
end | ||
end | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What goes wrong when building in parallel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The makefile is not written to support parallel compilation. It fails when enabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@not-me-for-sure Please report this to the upstream project as an issue and add a link to that issue here. We consider requiring no parallelisation as a bug as it slows things down a lot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stashapp/stash#5674
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@not-me-for-sure please add a Ruby comment in the formula providing context and linking to to this issue, thanks!