zig dependents: fix CPU target for arm64 Linux #213589
Open
+50
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlocab
added
CI-skip-dependents
github-actions
bot
added
the
zig
cho-m
reviewed
Mar 21, 2025
| cpu = case Hardware.oldest_cpu # See `zig targets`. | ||
| # Cortex A-53 seems to be the oldest available ARMv8-A processor. | ||
| # https://en.wikipedia.org/wiki/ARM_Cortex-A53 | ||
| when :armv8 then "cortex_a53" |
There was a problem hiding this comment.
Maybe one of the targets with only v8a would be more minimal? zig targets shows A-53 as:
.cortex_a53 = .{
"fpao",
"v8a",
},
I think the most minimal 64-bit v8a-only option is A-35 (as A-32 is 32-bit)
.cortex_a32 = .{
"v8a",
},
.cortex_a35 = .{
"v8a",
},
.cortex_a73 = .{
"v8a",
},
.kryo = .{
"v8a",
},
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?See #213501.