-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zig dependents: fix CPU target for arm64 Linux #213589
base: master
Are you sure you want to change the base?
Changes from all commits
bbd3c2f
eeb66b1
8b20712
db3b764
2986f57
dcbac9e
d4b3249
6d97e72
ef3e845
169e8f7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,11 +16,14 @@ | |
depends_on "zig" => :build | ||
depends_on :macos # does not build on linux | ||
|
||
def install | ||
Check failure on line 19 in Formula/b/bold.rb
|
||
# Fix illegal instruction errors when using bottles on older CPUs. | ||
# https://github.com/Homebrew/homebrew-core/issues/92282 | ||
cpu = case Hardware.oldest_cpu | ||
when :arm_vortex_tempest then "apple_m1" # See `zig targets`. | ||
cpu = case Hardware.oldest_cpu # See `zig targets`. | ||
# Cortex A-53 seems to be the oldest available ARMv8-A processor. | ||
# https://en.wikipedia.org/wiki/ARM_Cortex-A53 | ||
when :armv8 then "cortex_a53" | ||
when :arm_vortex_tempest then "apple_m1" | ||
else Hardware.oldest_cpu | ||
end | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,11 +19,14 @@ | |
|
||
depends_on "zig" | ||
|
||
def install | ||
Check failure on line 22 in Formula/f/flow-control.rb
|
||
# Fix illegal instruction errors when using bottles on older CPUs. | ||
# https://github.com/Homebrew/homebrew-core/issues/92282 | ||
cpu = case Hardware.oldest_cpu | ||
when :arm_vortex_tempest then "apple_m1" # See `zig targets`. | ||
cpu = case Hardware.oldest_cpu # See `zig targets`. | ||
# Cortex A-53 seems to be the oldest available ARMv8-A processor. | ||
# https://en.wikipedia.org/wiki/ARM_Cortex-A53 | ||
when :armv8 then "cortex_a53" | ||
when :arm_vortex_tempest then "apple_m1" | ||
else Hardware.oldest_cpu | ||
end | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,11 +16,14 @@ | |
|
||
depends_on "zig" => :build | ||
|
||
def install | ||
Check failure on line 19 in Formula/h/hevi.rb
|
||
# Fix illegal instruction errors when using bottles on older CPUs. | ||
# https://github.com/Homebrew/homebrew-core/issues/92282 | ||
cpu = case Hardware.oldest_cpu | ||
when :arm_vortex_tempest then "apple_m1" # See `zig targets`. | ||
cpu = case Hardware.oldest_cpu # See `zig targets`. | ||
# Cortex A-53 seems to be the oldest available ARMv8-A processor. | ||
# https://en.wikipedia.org/wiki/ARM_Cortex-A53 | ||
when :armv8 then "cortex_a53" | ||
when :arm_vortex_tempest then "apple_m1" | ||
else Hardware.oldest_cpu | ||
end | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe one of the targets with only v8a would be more minimal?
zig targets
shows A-53 as:I think the most minimal 64-bit v8a-only option is A-35 (as A-32 is 32-bit)