-
Notifications
You must be signed in to change notification settings - Fork 63
feat: Add migration for existing project #1424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… jy/migrate-existing-project
…-existing-project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few non-blocking comments, but LGTM
@@ -1,3 +1,4 @@ | |||
// @ts-nocheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious why the ts-nocheck
is even needed - doesn't seem like there would be any type issues with an object literal like this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments, mostly nits. I do think you should leave some comments in handleMigrationSetup
for posterity before merging.
…-existing-project
Description and Context
Adds
hs project migrate
to migrate an existing project from2023.2
tounstable
To test:
2023.2
and cd into the project dirctoryyarn hs project migrate
uids
enter them{project-location}/archive
and your new source code will be located in{project-location}/{project-source-dir}
. Thehsproject.json
file should be updated to have the correct platform version