Skip to content

feat: Add migration for existing project #1424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 75 commits into from
Apr 16, 2025
Merged

Conversation

joe-yeager
Copy link
Contributor

@joe-yeager joe-yeager commented Apr 3, 2025

Description and Context

Adds hs project migrate to migrate an existing project from 2023.2 to unstable

To test:

  • Find an existing project using 2023.2 and cd into the project dirctory
  • Run yarn hs project migrate
  • Select the app you would like to migrate
  • Confirm the migration
  • If prompted for uids enter them
  • Allow the migration to complete
  • Your pre-exisiting source code should be moved to {project-location}/archive and your new source code will be located in {project-location}/{project-source-dir}. The hsproject.json file should be updated to have the correct platform version

camden11
camden11 previously approved these changes Apr 15, 2025
Copy link
Contributor

@camden11 camden11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few non-blocking comments, but LGTM

@@ -1,3 +1,4 @@
// @ts-nocheck
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious why the ts-nocheck is even needed - doesn't seem like there would be any type issues with an object literal like this

kemmerle
kemmerle previously approved these changes Apr 15, 2025
Copy link
Contributor

@kemmerle kemmerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments, mostly nits. I do think you should leave some comments in handleMigrationSetup for posterity before merging.

@joe-yeager joe-yeager dismissed stale reviews from kemmerle and camden11 via 153ad7e April 15, 2025 19:49
kemmerle
kemmerle previously approved these changes Apr 15, 2025
brandenrodgers
brandenrodgers previously approved these changes Apr 16, 2025
@joe-yeager joe-yeager merged commit 66b9469 into main Apr 16, 2025
1 check passed
@joe-yeager joe-yeager deleted the jy/migrate-existing-project branch April 16, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants