Skip to content

Switch ome_zarr class from S3 to S4 - #36

Draft
Bisaloo wants to merge 1 commit into
mainfrom
s4-class
Draft

Switch ome_zarr class from S3 to S4#36
Bisaloo wants to merge 1 commit into
mainfrom
s4-class

Conversation

@Bisaloo

@Bisaloo Bisaloo commented Jun 23, 2026

Copy link
Copy Markdown
Member

Modelled after the class currently in spatialdataR.

This currently fails tests because I removed the [ method to not clash with what S4Vectors does.

We have two options:

  • use [ to extract levels and a crop() method to slice/crop image (S4Vectors + ImageArray strategy)
  • use [ to crop/slice and a extract_levels() method to extract levels. This is what we're doing on main.

@Artur-man, what do you think?

@Artur-man

Artur-man commented Jul 4, 2026

Copy link
Copy Markdown
Collaborator

I also wanted to separate the class from spatialdataR and make its own package, I think romeo might as well serve that purpose.

I do not know about SimpleList much but it comes with its own metadata right ? thats really convenient.

What you mean by "to not clash with what S4Vectors does", is that [ behaves differently for each SimpleList level ? that I did not understand.

@Artur-man

Artur-man commented Jul 4, 2026

Copy link
Copy Markdown
Collaborator

Ah by the way:

use [ to extract levels and a crop() method to slice/crop image (S4Vectors + ImageArray strategy)

I think in ImageArray, I use [[ method to extract levels (although we do not use the extract_levels method) but use [ for cropping where [ methods calls crop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants