Conversation
Collaborator
|
I also wanted to separate the class from spatialdataR and make its own package, I think romeo might as well serve that purpose. I do not know about What you mean by "to not clash with what S4Vectors does", is that |
Collaborator
|
Ah by the way:
I think in ImageArray, I use |
This was referenced Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modelled after the class currently in spatialdataR.
This currently fails tests because I removed the
[method to not clash with what S4Vectors does.We have two options:
[to extract levels and acrop()method to slice/crop image (S4Vectors + ImageArray strategy)[to crop/slice and aextract_levels()method to extract levels. This is what we're doing onmain.@Artur-man, what do you think?