Added enzymatic tissue dissociation fields #1599
Conversation
…nto ac-tissue-dissociation-Issue1592
json_schema/type/protocol/biomaterial_collection/dissociation_protocol.json
Outdated
Show resolved
Hide resolved
Co-authored-by: ESapenaVentura <[email protected]>
Co-authored-by: ESapenaVentura <[email protected]>
…nto ac-tissue-dissociation-Issue1592
arschat
requested review from
ESapenaVentura,
amnonkhen,
NoopDog,
hannes-ucsc and
ncalvanese1
| }, | ||
| "digestion_temperature": { | ||
| "description": "Temperature of digestion in Celsius or in general terms (i.e. cold, warm, room temperature).", | ||
| "pattern": "^(\\d+(\\.\\d+)?|frozen|cold|room temperature|warm)$", |
There was a problem hiding this comment.
The number pattern matches non-sensical strings such as 00000000021.210000000000. Consider a union (anyOf) of number and enum.
Then again, instead of allowing the subjective English terms, you could just allow for a range. That might be more elegant and easier to process for consumers.
There was a problem hiding this comment.
Thank you for your comment, I agree on using range instead of words however, the Lung bionetwork insisted on using words to record this, as they used in the published version 1 of their atlas.
I've added the solution with the union of types in 0944f6e .
| "Protease", | ||
| "TrypLE", | ||
| "Trypsin" | ||
| ] |
There was a problem hiding this comment.
This bracket seems misaligned.
There was a problem hiding this comment.
Thanks for pointing that out, fixed in 0944f6e
| }, | ||
| "digestion_temperature": { | ||
| "description": "Temperature of digestion in Celsius or in general terms (i.e. cold, warm, room temperature).", | ||
| "anyOf": [ |
There was a problem hiding this comment.
I was confused but
| "anyOf": [ | |
| "oneOf": [ |
is semantically equivalent (given that the alternatives are disjunctive) and adds clarity.
…nto ac-tissue-dissociation-Issue1592
#1592
Release notes
For
dissociation_protocol.jsonschema:reagentsfriendly name to distinguish withdigestion_solutiondigestion_timedigestion_time_unitsdigestion_temperaturedigestion_solutionReviews requested