Refactor JUnit 5 Tests for BaseTestDSASignatureInterop#1468
Open
Mohit-Rajbhar100698 wants to merge 1 commit into
Open
Refactor JUnit 5 Tests for BaseTestDSASignatureInterop#1468Mohit-Rajbhar100698 wants to merge 1 commit into
Mohit-Rajbhar100698 wants to merge 1 commit into
Conversation
Mohit-Rajbhar100698
force-pushed
the
refactor-junit5-BaseTestDSASignatureInterop-tests
branch
from
90700db to
edfcd4e
Compare
Mohit-Rajbhar100698
requested review from
KostasTsiounis,
jasonkatonica and
johnpeck-us-ibm
johnpeck-us-ibm
approved these changes
May 18, 2026
Mohit-Rajbhar100698
force-pushed
the
refactor-junit5-BaseTestDSASignatureInterop-tests
branch
from
edfcd4e to
893ded6
Compare
Mohit-Rajbhar100698
force-pushed
the
refactor-junit5-BaseTestDSASignatureInterop-tests
branch
from
893ded6 to
d9a6071
Compare
KostasTsiounis
requested changes
May 27, 2026
johnpeck-us-ibm
approved these changes
Jun 2, 2026
Mohit-Rajbhar100698
force-pushed
the
refactor-junit5-BaseTestDSASignatureInterop-tests
branch
2 times, most recently
from
8b658b3 to
f650a7d
Compare
Mohit-Rajbhar100698
requested review from
KostasTsiounis,
jasonkatonica and
johnpeck-us-ibm
Mohit-Rajbhar100698
force-pushed
the
refactor-junit5-BaseTestDSASignatureInterop-tests
branch
from
f650a7d to
4966270
Compare
KostasTsiounis
requested changes
Jun 4, 2026
Comment on lines
+32
to
+41
| switch (provider) { | ||
| case OpenJCEPlus: | ||
| loadProvider(TestProvider.OpenJCEPlus); | ||
| break; | ||
| case OpenJCEPlusFIPS: | ||
| loadProvider(TestProvider.OpenJCEPlusFIPS); | ||
| break; | ||
| default: | ||
| throw new Exception("Provider not supported: " + provider.getProviderName()); | ||
| } |
Member
There was a problem hiding this comment.
Should we extract this into a helper method?
Collaborator
Author
There was a problem hiding this comment.
ok , we can move this switch statement into a seperate helper method.
Done
| } | ||
|
|
||
| public void setAndInsertInteropProvider(TestProvider interopProvider) throws Exception { | ||
| switch (interopProvider) { |
Member
There was a problem hiding this comment.
Shouldn't we set the interop provider here with something like this.interopProvider = interopProvider? Since this variable is not available in BaseTest maybe this method belongs to BaseTestInterop.
Mohit-Rajbhar100698
force-pushed
the
refactor-junit5-BaseTestDSASignatureInterop-tests
branch
from
4966270 to
68fef36
Compare
Mohit-Rajbhar100698
force-pushed
the
refactor-junit5-BaseTestDSASignatureInterop-tests
branch
2 times, most recently
from
16b009d to
fc1b4a7
Compare
Replace multiple test classes extending BaseTestDSASignatureInterop with a single JUnit 5 parameterized test class Signed-off-by: Mohit Rajbhar <mohit.rajbhar@ibm.com>
Mohit-Rajbhar100698
force-pushed
the
refactor-junit5-BaseTestDSASignatureInterop-tests
branch
from
fc1b4a7 to
6a2c9e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace multiple test classes extending BaseTestDSASignatureInterop with a single JUnit 5 parameterized test class
Signed-off-by: Mohit Rajbhar mohit.rajbhar@ibm.com