Iceberg refactor into a separate lakehouse connector #1249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yingsu00
reviewed
Nov 3, 2025
| option(VELOX_ENABLE_AGGREGATES "Build aggregates." ON) | ||
| option(VELOX_ENABLE_HIVE_CONNECTOR "Build Hive connector." ON) | ||
| option(VELOX_ENABLE_HIVE_CONNECTOR "Build the Hive connector." ON) | ||
| #option(VELOX_ENABLE_HIVE_NEW_CONNECTOR "Build the new Hive connector." ON) |
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| #if(${VELOX_BUILD_TESTING}) |
There was a problem hiding this comment.
Can the tests run? If yes we need to uncomment this
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
There was a problem hiding this comment.
The file names should not be ConnectorXXX any more. They need to be called IcebergXXX
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
There was a problem hiding this comment.
Since it's already in the final leaf folder, there should not be XXXBase classes or files anymore. These Base classes shall be merged with the final classes, e.g. ConnectorConfigBase shall be merged into IcebergConfig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving all required classes for Iceberg into a new lakehouse connector removing dependencies on hive connector.