-
Notifications
You must be signed in to change notification settings - Fork 28
Improved formatting for ListLiterals in multi dimensional lists #1422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved formatting for ListLiterals in multi dimensional lists #1422
Conversation
…ut_of_imbricated_list_literals
|
Hi @alexanderpann, we have implemented your suggested solution with a static list length of 3 before a line break is enforced. Feel free to have a look at the examples provided. Thanks! |
alexanderpann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with this change.
fyi: @arimer
…ut_of_imbricated_list_literals
|
Hi @alexanderpann would you kindly have a look at the check that hasn't run successfully yet? |
|
@arimer Can you check why it is not building? |
|
TeamCity is configured to request approval for builds of PRs from forks (for security reasons). I triggered a build. |
|
@eyn9xwy the build failed because of some resolveInfo not being up-to-date. Run |
Head branch was pushed to by a user without write access
arimer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line break after a fixed lenght of 3 looks fine. Could you please update the Changelog before we can merge?
|
@arimer Done, thank you! |
…ut_of_imbricated_list_literals
…ut_of_imbricated_list_literals




This PR fixes an issue with the layout of list literals by using a new line when a threshold of three elements per list is exeeded.
