Skip to content

Conversation

@eyn9xwy
Copy link
Contributor

@eyn9xwy eyn9xwy commented Aug 20, 2025

This PR fixes an issue with the layout of list literals by using a new line when a threshold of three elements per list is exeeded.
image

@alexanderpann
Copy link
Member

Not sure what others think about it, but sometimes it feels like there are too many line breaks after this change and I am not sure if this helps with readability. Another option would be to only use breaks when the list literal contains a certain number of elements e.g. 3 or 5 or rather create a new concept for those matrix-style initialisations.

Bildschirmfoto 2025-08-28 um 17 29 18 Bildschirmfoto 2025-08-28 um 17 30 14

vs

Bildschirmfoto 2025-08-28 um 17 30 49

@eyn9xwy
Copy link
Contributor Author

eyn9xwy commented Aug 29, 2025

Fair point, but in our case the lists may look something like this:
image
There's no apparent structure, so I don't think a static rule like "line break after n elements" will do the trick.
I'll talk to my team about creating a new concept.

@eyn9xwy
Copy link
Contributor Author

eyn9xwy commented Sep 24, 2025

Hi @alexanderpann, we have implemented your suggested solution with a static list length of 3 before a line break is enforced. Feel free to have a look at the examples provided. Thanks!

alexanderpann
alexanderpann previously approved these changes Sep 25, 2025
Copy link
Member

@alexanderpann alexanderpann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with this change.

fyi: @arimer

@eyn9xwy
Copy link
Contributor Author

eyn9xwy commented Oct 8, 2025

Hi @alexanderpann would you kindly have a look at the check that hasn't run successfully yet?

@alexanderpann
Copy link
Member

@arimer Can you check why it is not building?

@sergej-koscejev
Copy link
Member

TeamCity is configured to request approval for builds of PRs from forks (for security reasons). I triggered a build.

@sergej-koscejev
Copy link
Member

@eyn9xwy the build failed because of some resolveInfo not being up-to-date. Run ./gradlew remigrate locally to fix this.

auto-merge was automatically disabled October 10, 2025 11:49

Head branch was pushed to by a user without write access

@arimer arimer requested a review from alexanderpann October 13, 2025 14:46
Copy link
Member

@arimer arimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line break after a fixed lenght of 3 looks fine. Could you please update the Changelog before we can merge?

@eyn9xwy
Copy link
Contributor Author

eyn9xwy commented Oct 14, 2025

@arimer Done, thank you!

@arimer arimer self-requested a review October 15, 2025 07:00
@arimer arimer enabled auto-merge October 15, 2025 07:07
@arimer arimer merged commit 84efa37 into IETS3:maintenance/mps20241 Oct 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants