Skip to content

Improved formatting for ListLiterals in multi dimensional lists #1422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arimer merged 9 commits into from
Oct 15, 2025
Merged

Improved formatting for ListLiterals in multi dimensional lists #1422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
28afed2
Improved formatting for ListLiterals in multi dimensional lists
eyn9xwy Aug 20, 2025
c0e5197
Merge branch 'maintenance/mps20241' into bugfix/bug_1421_improve_layo…
eyn9xwy Aug 20, 2025
588bbdc
Implemented suggested improvement for layout and some examples
eyn9xwy Sep 24, 2025
6e65780
Merge branch 'maintenance/mps20241' into bugfix/bug_1421_improve_layo…
eyn9xwy Sep 24, 2025
d6584fa
Merge branch 'maintenance/mps20241' into bugfix/bug_1421_improve_layo…
alexanderpann Oct 6, 2025
c43fb9a
Ran gradlew.bat remigrate locally
eyn9xwy Oct 10, 2025
636d47a
Update Changelog Oct 25
eyn9xwy Oct 14, 2025
555c3f0
Merge branch 'maintenance/mps20241' into bugfix/bug_1421_improve_layo…
alexanderpann Oct 15, 2025
0ebd1ef
Merge branch 'maintenance/mps20241' into bugfix/bug_1421_improve_layo…
alexanderpann Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ All notable changes to this project are documented in this file.
Format of the log is _loosely_ based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
The project does _not_ follow Semantic Versioning and the changes are documented in reverse chronological order, grouped by calendar month.

## October 2025

### Fixed
- Improved the readability of lists by enforcing a new line when a threshold of three elements per list is exeeded.

## September 2025

### Added
Expand Down
72 changes: 72 additions & 0 deletions ...anguages/org.iets3.opensource/languages/org.iets3.core.expr.collections/models/editor.mps
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
</concept>
<concept id="6089045305654894366" name="jetbrains.mps.lang.editor.structure.SubstituteMenuReference_Default" flags="ng" index="2kknPJ" />
<concept id="1237303669825" name="jetbrains.mps.lang.editor.structure.CellLayout_Indent" flags="nn" index="l2Vlx" />
<concept id="1237307900041" name="jetbrains.mps.lang.editor.structure.IndentLayoutIndentStyleClassItem" flags="ln" index="lj46D" />
<concept id="784421273959492578" name="jetbrains.mps.lang.editor.structure.TransformationMenuPart_IncludeMenu" flags="ng" index="mvV$s">
<child id="784421273959492606" name="nodeFunction" index="mvV$0" />
</concept>
Expand Down Expand Up @@ -175,11 +176,13 @@
<concept id="1070533707846" name="jetbrains.mps.baseLanguage.structure.StaticFieldReference" flags="nn" index="10M0yZ">
<reference id="1144433057691" name="classifier" index="1PxDUh" />
</concept>
<concept id="1070534370425" name="jetbrains.mps.baseLanguage.structure.IntegerType" flags="in" index="10Oyi0" />
<concept id="1070534934090" name="jetbrains.mps.baseLanguage.structure.CastExpression" flags="nn" index="10QFUN">
<child id="1070534934091" name="type" index="10QFUM" />
<child id="1070534934092" name="expression" index="10QFUP" />
</concept>
<concept id="1068431474542" name="jetbrains.mps.baseLanguage.structure.VariableDeclaration" flags="ng" index="33uBYm">
<property id="1176718929932" name="isFinal" index="3TUv4t" />
<child id="1068431790190" name="initializer" index="33vP2m" />
</concept>
<concept id="1513279640923991009" name="jetbrains.mps.baseLanguage.structure.IGenericClassCreator" flags="ngI" index="366HgL">
Expand Down Expand Up @@ -215,6 +218,7 @@
<concept id="1079359253375" name="jetbrains.mps.baseLanguage.structure.ParenthesizedExpression" flags="nn" index="1eOMI4">
<child id="1079359253376" name="expression" index="1eOMHV" />
</concept>
<concept id="1081506762703" name="jetbrains.mps.baseLanguage.structure.GreaterThanExpression" flags="nn" index="3eOSWO" />
<concept id="1204053956946" name="jetbrains.mps.baseLanguage.structure.IMethodCall" flags="ngI" index="1ndlxa">
<reference id="1068499141037" name="baseMethodDeclaration" index="37wK5l" />
<child id="1068499141038" name="actualArgument" index="37wK5m" />
Expand Down Expand Up @@ -490,6 +494,74 @@
<property role="VOm3f" value="true" />
</node>
</node>
<node concept="pVoyu" id="1B_b0w81IxR" role="3F10Kt">
<property role="VOm3f" value="true" />
<node concept="3nzxsE" id="1B_b0w833HR" role="3n$kyP">
<node concept="3clFbS" id="1B_b0w833HS" role="2VODD2">
<node concept="3cpWs8" id="qeznuD1TxR" role="3cqZAp">
<node concept="3cpWsn" id="qeznuD1TxS" role="3cpWs9">
<property role="TrG5h" value="THRESHOLD_FOR_NEW_LINES" />
<property role="3TUv4t" value="true" />
<node concept="10Oyi0" id="qeznuD1RGt" role="1tU5fm" />
<node concept="3cmrfG" id="qeznuD1TxT" role="33vP2m">
<property role="3cmrfH" value="3" />
</node>
</node>
</node>
<node concept="3clFbF" id="1B_b0w837L0" role="3cqZAp">
<node concept="1Wc70l" id="qeznuD07mQ" role="3clFbG">
<node concept="2OqwBi" id="1B_b0w8380K" role="3uHU7B">
<node concept="2OqwBi" id="1B_b0w837Lx" role="2Oq$k0">
<node concept="pncrf" id="1B_b0w837KZ" role="2Oq$k0" />
<node concept="1mfA1w" id="1B_b0w837PF" role="2OqNvi" />
</node>
<node concept="1mIQ4w" id="1B_b0w838lP" role="2OqNvi">
<node concept="chp4Y" id="1B_b0w838ot" role="cj9EA">
<ref role="cht4Q" to="700h:6zmBjqUinVn" resolve="ListLiteral" />
</node>
</node>
</node>
<node concept="1eOMI4" id="qeznuD1Ph3" role="3uHU7w">
<node concept="3eOSWO" id="qeznuD0jD$" role="1eOMHV">
<node concept="37vLTw" id="qeznuD1TxU" role="3uHU7w">
<ref role="3cqZAo" node="qeznuD1TxS" resolve="THRESHOLD_FOR_NEW_LINES" />
</node>
<node concept="2OqwBi" id="qeznuD0cQJ" role="3uHU7B">
<node concept="2OqwBi" id="qeznuD07QZ" role="2Oq$k0">
<node concept="pncrf" id="qeznuD07ob" role="2Oq$k0" />
<node concept="3Tsc0h" id="qeznuD09Sn" role="2OqNvi">
<ref role="3TtcxE" to="700h:6zmBjqUinVo" resolve="elements" />
</node>
</node>
<node concept="34oBXx" id="qeznuD0gJp" role="2OqNvi" />
</node>
</node>
</node>
</node>
</node>
</node>
</node>
</node>
<node concept="lj46D" id="1B_b0w84d$8" role="3F10Kt">
<property role="VOm3f" value="true" />
<node concept="3nzxsE" id="1B_b0w84d_6" role="3n$kyP">
<node concept="3clFbS" id="1B_b0w84d_7" role="2VODD2">
<node concept="3clFbF" id="1B_b0w84ecS" role="3cqZAp">
<node concept="2OqwBi" id="1B_b0w84ecT" role="3clFbG">
<node concept="2OqwBi" id="1B_b0w84ecU" role="2Oq$k0">
<node concept="pncrf" id="1B_b0w84ecV" role="2Oq$k0" />
<node concept="1mfA1w" id="1B_b0w84ecW" role="2OqNvi" />
</node>
<node concept="1mIQ4w" id="1B_b0w84ecX" role="2OqNvi">
<node concept="chp4Y" id="1B_b0w84ecY" role="cj9EA">
<ref role="cht4Q" to="700h:6zmBjqUinVn" resolve="ListLiteral" />
</node>
</node>
</node>
</node>
</node>
</node>
</node>
</node>
<node concept="3EZMnI" id="4399ITQA59t" role="6VMZX">
<node concept="3F0ifn" id="4399ITQA59x" role="3EZMnx">
Expand Down
Loading