Skip to content

Comments

Handle partial success for desinventar#48

Merged
tnagorra merged 3 commits intomainfrom
fix/desinventar-typesafe
Mar 22, 2025
Merged

Handle partial success for desinventar#48
tnagorra merged 3 commits intomainfrom
fix/desinventar-typesafe

Conversation

@tnagorra
Copy link
Member

  • Implement pyndantic validator for desinventar transformer
  • Use generators to process desinventar events and impacts
  • Add pydantic

- Implement pyndantic validator for desinventar transformer
- Use generators to process desinventar events and impacts
- Add pydantic
@tnagorra tnagorra marked this pull request as ready for review March 22, 2025 08:54
- Update use of geocoder
@tnagorra tnagorra merged commit a0c834c into main Mar 22, 2025
5 of 6 checks passed
@thenav56 thenav56 deleted the fix/desinventar-typesafe branch March 22, 2025 11:30
@emmanuelmathot
Copy link
Collaborator

Please do not merge if not all test passes

@tnagorra
Copy link
Member Author

@emmanuelmathot We recently introduced pre-commit which are additional checks.
The check that is failing is actually related to formatting.

We can run an autofixer to fix all issues. We are waiting for existing PR to be merged before we run them to avoid adding un-necessary merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants