Skip to content

Conversation

qqmyers
Copy link
Member

@qqmyers qqmyers commented Sep 10, 2025

What this PR does / why we need it: As noted in the issue, while #11203 fixed some issues related to whether guestbook entries are displayed properly depending on whether a guestbook is enabled and whether guesstbook-at-request is enabled, it introduced a couple new issues. This PR should resolve those.

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this: There are three variables:

  • Whether a guestbook is in use for a dataset
  • Whether guestbook at request is enabled (or guestbooks appear at download)
  • Whether terms of access are set and thus need to be shown at request access and download time.

There are also multiple ways to request access and download:

  • selecting files in the dataset file table and using the main menu
  • using the individual file menu in the dataset file table
  • from the file page

Nominally the code should do the right thing in all cases - guestbook questions should only appear when a guestbook is in use and only when requesting access (gb at request set) or download time - regardless of how the user makes those request access/download actions.

This PR should nominally only fix the two cases in #11800, but regression testing all cases is probably worthwhile (and would have caught these issues in #11203) - giving this a size 10 for QA testing.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?: inc.

Additional documentation:

hide guestbook when not used, add missing method to FilePage/file.xhtml
@qqmyers qqmyers added the Size: 10 A percentage of a sprint. 7 hours. label Sep 10, 2025
@qqmyers qqmyers moved this to Ready for Triage in IQSS Dataverse Project Sep 10, 2025
@qqmyers qqmyers added this to the 6.9 milestone Sep 10, 2025
@coveralls
Copy link

coveralls commented Sep 10, 2025

Coverage Status

coverage: 23.541% (+0.002%) from 23.539%
when pulling ef858a9 on QualitativeDataRepository:IQSS/11800-GB-request_access_errors
into f79a02b on IQSS:develop.

@ofahimIQSS ofahimIQSS moved this from Ready for Triage to Ready for Review ⏩ in IQSS Dataverse Project Sep 16, 2025
@cmbz cmbz added FY26 Sprint 6 FY26 Sprint 6 (2025-09-10 - 2025-09-24) FY26 Sprint 7 FY26 Sprint 7 (2025-09-24 - 2025-10-08) labels Sep 24, 2025
@cmbz cmbz added the FY26 Sprint 8 FY26 Sprint 8 (2025-10-08 - 2025-10-22) label Oct 8, 2025
@stevenwinship stevenwinship self-assigned this Oct 14, 2025
@stevenwinship stevenwinship moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Oct 14, 2025
@github-project-automation github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Oct 14, 2025
@stevenwinship stevenwinship removed their assignment Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 6 FY26 Sprint 6 (2025-09-10 - 2025-09-24) FY26 Sprint 7 FY26 Sprint 7 (2025-09-24 - 2025-10-08) FY26 Sprint 8 FY26 Sprint 8 (2025-10-08 - 2025-10-22) Size: 10 A percentage of a sprint. 7 hours.

Projects

Status: Ready for QA ⏩

4 participants