IQSS/11800 Fix GB - Request Access errors #11808
Open
+10
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: As noted in the issue, while #11203 fixed some issues related to whether guestbook entries are displayed properly depending on whether a guestbook is enabled and whether guesstbook-at-request is enabled, it introduced a couple new issues. This PR should resolve those.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this: There are three variables:
There are also multiple ways to request access and download:
Nominally the code should do the right thing in all cases - guestbook questions should only appear when a guestbook is in use and only when requesting access (gb at request set) or download time - regardless of how the user makes those request access/download actions.
This PR should nominally only fix the two cases in #11800, but regression testing all cases is probably worthwhile (and would have caught these issues in #11203) - giving this a size 10 for QA testing.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: inc.
Additional documentation: