Skip to content

CLI: Return non-zero on unknown sub commands #7162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2019

Conversation

dnsmichi
Copy link
Contributor

@dnsmichi dnsmichi commented May 7, 2019

Tests

michi@mbpmif ~/dev/icinga/icinga2 (master *=) $ icinga2 sdfsdfsdf; echo "Status Code:$?"
[2019-05-07 12:40:54 +0200] critical/icinga-app: Command parsing error. Try '--help'.
Status Code:1
michi@mbpmif ~/dev/icinga/icinga2 (master *=) $ icinga2 daemon -C; echo "Status Code:$?"
[2019-05-07 12:41:08 +0200] information/cli: Icinga application loader (version: v2.10.4-643-gaa88271d5; debug)
[2019-05-07 12:41:08 +0200] information/cli: Loading configuration file(s).
[2019-05-07 12:41:08 +0200] information/ConfigItem: Committing config item(s).
[2019-05-07 12:41:08 +0200] information/ApiListener: My API identity: mbpmif.int.netways.de
[2019-05-07 12:41:08 +0200] information/ConfigItem: Instantiated 2 Hosts.
[2019-05-07 12:41:08 +0200] information/ConfigItem: Instantiated 1 HostGroup.
[2019-05-07 12:41:08 +0200] information/ConfigItem: Instantiated 1 Endpoint.
[2019-05-07 12:41:08 +0200] information/ConfigItem: Instantiated 1 IcingaApplication.
[2019-05-07 12:41:08 +0200] information/ConfigItem: Instantiated 1 CheckerComponent.
[2019-05-07 12:41:08 +0200] information/ConfigItem: Instantiated 3 Zones.
[2019-05-07 12:41:08 +0200] information/ConfigItem: Instantiated 1 IdoMysqlConnection.
[2019-05-07 12:41:08 +0200] information/ConfigItem: Instantiated 1 NotificationComponent.
[2019-05-07 12:41:08 +0200] information/ConfigItem: Instantiated 1 ApiListener.
[2019-05-07 12:41:08 +0200] information/ConfigItem: Instantiated 7 CheckCommands.
[2019-05-07 12:41:08 +0200] information/ConfigItem: Instantiated 1 FileLogger.
[2019-05-07 12:41:08 +0200] information/ConfigItem: Instantiated 1 ApiUser.
[2019-05-07 12:41:08 +0200] information/ScriptGlobal: Dumping variables to file '/usr/local/icinga/icinga2/var/cache/icinga2/icinga2.vars'
[2019-05-07 12:41:08 +0200] information/cli: Finished validating the configuration file(s).
Status Code:0
michi@mbpmif ~/dev/icinga/icinga2 (master *=) $ icinga2 daemon --bumsti; echo "Status Code:$?"
[2019-05-07 12:41:22 +0200] critical/icinga-app: Error while parsing command-line options: unrecognised option '--bumsti'
Status Code:1

Auto-completion.

michi@mbpmif ~/dev/icinga/icinga2 (master *=) $ icinga2 daemon --
--close-stdio      --config           --define           --help             --log-level        --script-debugger  --version
--color            --daemonize        --errorlog         --include          --no-config        --validate
michi@mbpmif ~/dev/icinga/icinga2 (master *=) $ icinga2
api           ca            console       daemon        feature       node          object        pki           troubleshoot  variable

fixes #6585

@dnsmichi dnsmichi added bug Something isn't working area/cli Command line helpers labels May 7, 2019
@dnsmichi dnsmichi added this to the 2.11.0 milestone May 7, 2019
@dnsmichi dnsmichi merged commit 11dc304 into master May 7, 2019
@dnsmichi dnsmichi deleted the bugfix/cli-no-command-status-code branch May 7, 2019 11:23
@dnsmichi
Copy link
Contributor Author

Unfortunately this breaks the way our CLI commands work. Reverted.

@dnsmichi dnsmichi removed this from the 2.11.0 milestone May 10, 2019
@Al2Klimov Al2Klimov added this to the 2.11.0 milestone Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Command line helpers bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icinga2 and Icingacli should return nonzero status code on invalid parameters
2 participants