Upgrade github actions agents to latest#363
Conversation
|
|
||
| - name: Configure Windows | ||
| if: matrix.os == 'windows-latest' | ||
| if: ${{ startsWith(matrix.os, 'windows') }} |
There was a problem hiding this comment.
If we change the name from 2019 to latest, then this will prevent bugs
| - uses: actions/checkout@v3 | ||
| with: | ||
| fetch-depth: 0 | ||
| - uses: actions/setup-dotnet@v4 |
There was a problem hiding this comment.
Fix crash when using the wrong dotnet core
| rem https://github.com/actions/setup-python/issues/121 | ||
| echo %PREFIX_BEG% Configure %SUFFIX% | ||
| cmake %SOURCE_DIR% -G%COMPILER% -B%BUILD_DIR% %BUILD_PARAM% | ||
| cmake %SOURCE_DIR% -G%COMPILER% -B%BUILD_DIR% %BUILD_PARAM% -A x64 |
There was a problem hiding this comment.
Fix crash when trying to accidentally build 32-bit version
|
|
||
| - name: Package Python 3.8 and earlier | ||
| if: matrix.os == 'ubuntu-latest' && matrix.pyver != '3.9' && matrix.pyver != '3.10' && matrix.pyver != '3.11' && matrix.pyver != '3.12' && matrix.pyver != '3.13' | ||
| if: ${{ startsWith(matrix.os, 'ubuntu') && matrix.pyver != '3.9' && matrix.pyver != '3.10' && matrix.pyver != '3.11' && matrix.pyver != '3.12' && matrix.pyver != '3.13' }} |
There was a problem hiding this comment.
why does matrix.pyver <= '3.8' not work here?
There was a problem hiding this comment.
Because it is a string
There was a problem hiding this comment.
sorry i meant are we explicitly checking that the version is anything below 3.9, meaning, we dont know what version it will be? or can we just do matrix.pyver == '3.8'
| run: | | ||
| python -m pip install --upgrade pip setuptools wheel numpy | ||
| tools\package.bat Release "Visual Studio 16 2019" package_wheel "-DENABLE_APPS=OFF -DENABLE_EXAMPLES=OFF -DENABLE_CSHARP=OFF -DPython_EXECUTABLE=${{ steps.cpver.outputs.python-path }}" -DENABLE_PORTABLE=ON -A x64 | ||
| tools\package.bat Release "Visual Studio 17 2022" package_wheel "-DENABLE_APPS=OFF -DENABLE_EXAMPLES=OFF -DENABLE_CSHARP=OFF -DPython_EXECUTABLE=${{ steps.cpver.outputs.python-path }}" -DENABLE_PORTABLE=ON -A x64 |
There was a problem hiding this comment.
2022 is guaranteed to exist on the newest windows agents?
There was a problem hiding this comment.
We have to set this explicitly as far as I can tell
2 participants
Fix the deprecated windows-2019 agent issue
actions/runner-images#12045
Move all agents to latest to prevent future issues.