-
Notifications
You must be signed in to change notification settings - Fork 29
Upgrade github actions agents to latest #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
2dc0c49
Upgrade github actions agents to latest
ezralanglois 36cd08e
Fix bug
ezralanglois bad3981
Fix more issues
ezralanglois fe27a83
Upgrade windows compiler
ezralanglois b7152f0
Improve robustness and downgrade mac for dotnet
ezralanglois 5ef7fce
Try with update arch
ezralanglois 586c4cd
Fix mac
ezralanglois d57e84f
Fix mac
ezralanglois f4e9378
Fix mac
ezralanglois f21b5e9
Fix mac
ezralanglois a200279
Fix mac
ezralanglois 4e08b80
Fix mac
ezralanglois 5d5f7da
Fix mac
ezralanglois 017b760
Fix mac
ezralanglois a630a86
Fix mac
ezralanglois d52b8f3
Fix mac
ezralanglois 9494b28
Fix bug
ezralanglois a7ccca7
Fix bug
ezralanglois caa48d5
Fix bug
ezralanglois 9fe294b
Fix bug
ezralanglois f4488d7
Fix mac bug
ezralanglois 7fa45e8
Tmp fix windows
ezralanglois 4941901
Tmp fix windows
ezralanglois 48c7b8c
Tmp fix windows
ezralanglois f7e8be8
Fix missing arg
ezralanglois b8a80d1
Try reducing threads
ezralanglois dd5c668
Fix bug
ezralanglois cfdd739
Try another fix
ezralanglois bf39eef
Try another windows VM
ezralanglois 474b98c
Try something more
ezralanglois 2ac5fc2
Another fix
ezralanglois 2fb32e8
Ensure taking fix
ezralanglois a77756d
Try fix
ezralanglois 088f42a
Fix again
ezralanglois f78c405
Try updating swig
ezralanglois a57a523
Add token
ezralanglois 171f2a2
Workaround MSVC segfault
ezralanglois File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,13 +12,16 @@ jobs: | |
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| matrix: | ||
| os: [ubuntu-latest, windows-latest, macOS-13] | ||
| os: [ubuntu-latest, windows-latest, macOS-latest] | ||
| buildtype: ["Debug", "Release"] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| with: | ||
| fetch-depth: 0 | ||
| - uses: actions/setup-dotnet@v4 | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix crash when using the wrong dotnet core |
||
| with: | ||
| dotnet-version: '8.0.x' | ||
|
|
||
| - name: Setup Git name | ||
| run: | | ||
|
|
@@ -28,31 +31,31 @@ jobs: | |
| mkdir dist | ||
|
|
||
| - name: Configure Windows | ||
| if: matrix.os == 'windows-latest' | ||
| if: ${{ startsWith(matrix.os, 'windows') }} | ||
| run: cmake ${{github.workspace}} -Ax64 -B${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{matrix.buildtype}} -DPACKAGE_OUTPUT_FILE_PREFIX=${{github.workspace}}/dist -DENABLE_SWIG=ON -DENABLE_PORTABLE=ON -DENABLE_EXAMPLES=OFF -DENABLE_CSHARP=ON -DENABLE_PYTHON=OFF -DCSHARP_TEST_FRAMEWORK=netcoreapp8 | ||
|
|
||
| - name: Install Swig | ||
| if: matrix.os == 'macOS-13' | ||
| if: ${{ startsWith(matrix.os, 'macOS') }} | ||
| run: pip install swig==4.0.2 --prefix="$(pwd)/usr" | ||
|
|
||
| - name: Configure OSX | ||
| if: matrix.os == 'macOS-13' | ||
| run: cmake ${{github.workspace}} -B${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{matrix.buildtype}} -DPACKAGE_OUTPUT_FILE_PREFIX=${{github.workspace}}/dist -DENABLE_SWIG=ON -DENABLE_PORTABLE=ON -DENABLE_EXAMPLES=OFF -DENABLE_CSHARP=ON -DENABLE_PYTHON=OFF -DCSHARP_TEST_FRAMEWORK=netcoreapp8 -DSWIG_EXECUTABLE=$(ls $(pwd)/usr/lib/python3.*/site-packages/swig/data/bin/swig) -DSWIG_DIR=$(dirname $(ls $(pwd)/usr/lib/python3.*/site-packages/swig/data/share/swig/4.0.2/swig.swg)) | ||
| if: ${{ startsWith(matrix.os, 'macOS') }} | ||
| run: cmake ${{github.workspace}} -B${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{matrix.buildtype}} -DPACKAGE_OUTPUT_FILE_PREFIX=${{github.workspace}}/dist -DENABLE_SWIG=ON -DENABLE_PORTABLE=ON -DENABLE_EXAMPLES=OFF -DENABLE_CSHARP=ON -DENABLE_PYTHON=OFF -DCSHARP_TEST_FRAMEWORK=netcoreapp9 -DSWIG_EXECUTABLE=$(ls $(pwd)/usr/lib/python3.*/site-packages/swig/data/bin/swig) -DSWIG_DIR=$(dirname $(ls $(pwd)/usr/lib/python3.*/site-packages/swig/data/share/swig/4.0.2/swig.swg)) -DDotNetStandard_EXECUTABLE=${{env.DOTNET_ROOT}}/dotnet | ||
|
|
||
| - name: Build OSX and Windows | ||
| if: matrix.os != 'ubuntu-latest' | ||
| if: ${{ !startsWith(matrix.os, 'ubuntu') }} | ||
| run: cmake --build build --config ${{matrix.buildtype}} | ||
|
|
||
| - name: Test OSX and Windows | ||
| if: matrix.os != 'ubuntu-latest' | ||
| if: ${{ !startsWith(matrix.os, 'ubuntu') }} | ||
| run: cmake --build build --config ${{matrix.buildtype}} --target check | ||
|
|
||
| - name: Package OSX and Windows | ||
| if: matrix.os != 'ubuntu-latest' | ||
| if: ${{ !startsWith(matrix.os, 'ubuntu') }} | ||
| run: cmake --build build --config ${{matrix.buildtype}} --target nupack | ||
|
|
||
| - name: Linux Build, Test and Package in Docker | ||
| if: matrix.os == 'ubuntu-latest' | ||
| if: ${{ startsWith(matrix.os, 'ubuntu') }} | ||
| run: docker run --rm -v ${{github.workspace}}/:/io ezralanglois/interop bash -c "cmake /io -Bbuild -DCMAKE_BUILD_TYPE=${{matrix.buildtype}} -DPACKAGE_OUTPUT_FILE_PREFIX=/io/dist -DENABLE_SWIG=ON -DENABLE_PORTABLE=ON -DENABLE_EXAMPLES=OFF -DENABLE_CSHARP=ON -DENABLE_PYTHON=OFF && cmake --build build && cmake --build build --target check && cmake --build build --target nupack" | ||
|
|
||
| - name: Test Artifacts | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -94,7 +94,7 @@ rem ---------------------------------------------------------------------------- | |
|
|
||
| rem https://github.com/actions/setup-python/issues/121 | ||
| echo %PREFIX_BEG% Configure %SUFFIX% | ||
| cmake %SOURCE_DIR% -G%COMPILER% -B%BUILD_DIR% %BUILD_PARAM% | ||
| cmake %SOURCE_DIR% -G%COMPILER% -B%BUILD_DIR% %BUILD_PARAM% -A x64 | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix crash when trying to accidentally build 32-bit version |
||
| if "%errorlevel%" == "0" goto CONFIGURE_SUCCESS | ||
| set level=%errorlevel% | ||
| type %BUILD_DIR%\CMakeFiles\CMakeError.log | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we change the name from 2019 to latest, then this will prevent bugs