Skip to content

User data example #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

User data example #396

wants to merge 8 commits into from

Conversation

barneydobson
Copy link
Collaborator

@barneydobson barneydobson commented Apr 2, 2025

Description

  • Add a notebook demonstrating using custom data

Fixes #370 (raised by @meghnathomas )

  • Organise notebooks separately from guides

Fixes #393 (raised by @cbuahin )

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. python -m sphinx -b html docs docs/build)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

@barneydobson barneydobson changed the base branch from main to real-network-demo April 2, 2025 13:37
@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.84%. Comparing base (500f41c) to head (588772e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #396      +/-   ##
==========================================
- Coverage   88.06%   87.84%   -0.22%     
==========================================
  Files          23       23              
  Lines        2279     2279              
  Branches      287      287              
==========================================
- Hits         2007     2002       -5     
- Misses        193      194       +1     
- Partials       79       83       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've a question, but otherwise this looks fine.

Copy link
Collaborator

@cheginit cheginit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Please check the rendered version of the notebooks for warnings. There are quite a few warnings in this notebook.

@barneydobson barneydobson mentioned this pull request Apr 7, 2025
@barneydobson barneydobson mentioned this pull request Apr 29, 2025
10 tasks
Base automatically changed from real-network-demo to main April 29, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More notebooks User provided data demo
4 participants