WIP: PEP 688 demonstration#5665
Draft
blowekamp wants to merge 1 commit intoInsightSoftwareConsortium:mainfrom
Draft
WIP: PEP 688 demonstration#5665blowekamp wants to merge 1 commit intoInsightSoftwareConsortium:mainfrom
blowekamp wants to merge 1 commit intoInsightSoftwareConsortium:mainfrom
Conversation
github-actions
bot
added
area:Python wrapping
Member
Author
|
@thewtex I don' have any intention of taking this change further. I am just sharing the code in case it's useful for exploring this new python feature in ITK Python. It has recently been implemented in SimpleITK. This PR can be closed without merging. |
Experiment with implementing PEP 688. Replace __array__ with __buffer__. Convert memoryview to correctly specified n-d view. PEP 688 automatically maintains a a reference to the provider of the buffer. Add incomplete wrapping for the import image container, and buffer interface.
github-actions
bot
removed
the
area:Filtering
Member
|
@blowekamp wow! Awesome! Thank you so much for contributing this! I'll push it forward |
7 tasks
Member
Author
|
There may additional useful information related to this here: SimpleITK/SimpleITK#2447 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sharing code I wrote to play around with PEP 688 in ITK Python.