Skip to content

cardano-testnet: show in types the two scenarios that are supported #6155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Mar 17, 2025

Warning

This PR does not compile, this is intended. This is for demonstration only.

This PR is meant to show possible follow-ups of #6148, i.e. how we would implement these remarks of mine:

Have pTestnetNodeOptions return a list of TestnetNodeOption and TestnetNodeOption be UserProvidedNodeOptions Filepath | SpoNodeOptions [Srting] | RelayNodeOptions [ String]. In other words merge the types TestnetNodeOptions and AutomaticNodeOption. This will generalize the behavior so that the user can create multiple nodes, no matter whether they are using custom options or using default behavior (Spo or Relay). This will require a bit of generalization in Cardano.hs but not much.

This is shown in the first commit of this PR.

Reflect in the types the tying behavior between the node configuration file being passed by the user and the genesis files being passed by the user too.

This is shown in commits 2 and 3 of this PR

Base automatically changed from smelc/testnet-pass-config-files-2 to master March 17, 2025 19:53
Copy link

github-actions bot commented May 2, 2025

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label May 2, 2025
@carbolymer carbolymer removed the Stale label May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants