cardano-testnet: allow to take node configuration file as input #6148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Jimbo4350
approved these changes
Mar 14, 2025
| else | ||
| -- Here we forbid mixing defaulting of genesis files with providing a user node configuration file: | ||
| -- | ||
| -- Because of this check, either the user passes a node configuration file AND he passes all the genesis files. |
|
|
||
| -- Make Non P2P topology files | ||
| forM_ (zip [1..] portNumbers) $ \(i, myPortNumber) -> do | ||
| -- TODO: if the user provided its own configuration file, and requested a P2P topology file, |
Contributor
There was a problem hiding this comment.
Can you turn this into an issue so we can track it?
| <> testnetNodeExtraCliArgs nodeOptions | ||
| <> maybe [] extraCliArgs nodeOptions | ||
| pure $ eRuntime <&> \rt -> rt{poolKeys=mKeys} | ||
| -- TODO log the node's pid in a file. This is useful for killing the node later. |
Contributor
There was a problem hiding this comment.
If this is deserving of an issue can you create it?
smelc
force-pushed
the
smelc/testnet-pass-config-files-2
branch
from
2f5e95e to
3ae3a62
Compare
This was referenced Mar 17, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
If this design is chosen (over #6103), then cardano-foundation/developer-portal#1426 needs to be amended correspondingly
Description
Fixes #6069
Fixes #6137
Variant of #6103 where passing the node configuration file and the genesis files are tied:
cardano-testnetgenerates everything for youFollow-up issues to create
@Jimbo4350> please tick them if you agree 🙂 I'll create them
pTestnetNodeOptionsreturn a list ofTestnetNodeOptionandTestnetNodeOptionbeUserProvidedNodeOptions Filepath | SpoNodeOptions [Srting] | RelayNodeOptions [ String]. In other words merge the typesTestnetNodeOptionsandAutomaticNodeOption. This will generalize the behavior so that the user can create multiple nodes, no matter whether they are using custom options or using default behavior (SpoorRelay). This will require a bit of generalization in Cardano.hs but not much.ChangeDecided againstcardanoTestnetto takeFilepathfor genesis files instead of Haskell values, maybe?runTestnet: don't tie it with H.Integration #6122Checklist