Skip to content

cardano-node: Periodic Ledger Metrics Tracer #6180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jutaro
Copy link
Contributor

@jutaro jutaro commented Apr 16, 2025

This PR introduces a new periodic LedgerMetrics tracer and removes obsolete or redundant tracing infrastructure to simplify and modernize metrics reporting in the node.

Summary of Changes

  • Replaces StartLeadershipCheckPlus with a dedicated periodic tracer: LedgerMetrics.
  • Removes the unused ForgeTracerType.
  • Introduces a configurable frequency (ledgerMetricsFrequency) for emitting ledger metrics.
    • Ledger metrics are now emitted every Nth slot, configurable via the node config.
    • Tracing occurs approximately 700ms after slot start.
  • If ledgerMetricsFrequency: 0, the tracer is disabled.
  • The same logic applies to other periodic tracers, such as:
    • PeersTracer
    • ResourceTracer
    • These are also disabled via 0 frequency in config.

@jutaro jutaro requested a review from mgmeier April 16, 2025 09:53
@jutaro jutaro force-pushed the jutaro/periodic-tracer-v2 branch from a23e998 to d8b4a21 Compare April 17, 2025 07:26
@jutaro jutaro marked this pull request as ready for review April 17, 2025 08:06
@jutaro jutaro requested review from a team as code owners April 17, 2025 08:06
@jutaro jutaro marked this pull request as draft April 17, 2025 08:25
@jutaro jutaro force-pushed the jutaro/periodic-tracer-v2 branch 2 times, most recently from b6a39b5 to 60ad2f8 Compare April 28, 2025 08:02
@jutaro jutaro force-pushed the jutaro/periodic-tracer-v2 branch from e0c1e5c to e1e248e Compare May 12, 2025 08:40
ledger metrics 700ms after slot start
allow for not running periodic tracers
LedgerMetrics with delay, comments and defaults
Commented out drepCount and drepMapSize
@jutaro jutaro force-pushed the jutaro/periodic-tracer-v2 branch from e1e248e to 8e5e0c5 Compare May 14, 2025 10:40
@jutaro jutaro force-pushed the jutaro/periodic-tracer-v2 branch from 8e5e0c5 to dfbfe47 Compare May 14, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant