consensus: integrate HeaderWithTime
#6211
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tracing system is modified to effectively ignore `HeaderWithTime` by dropping the time annotations and using the underlying `Header`, keeping the old behaviour.
geo2a
force-pushed
the
geo2a/10.X-header-with-time
branch
from
b22e356 to
ff6ac6f
Compare
github-merge-queue bot
pushed a commit
to IntersectMBO/ouroboros-consensus
that referenced
this pull request
May 8, 2025
This is a follow-up to #1288 that ensures - do not expose `HeaderWithTime` in `TraceGDDEvent` via `GDDDebugInfo` - do not store the chain fragment with `HeaderWithTime` in `DensityBounds` adding the "no changelog'' label, as the relevant changelog fragments are already included into "main" Draft PR to for integration with the node: IntersectMBO/cardano-node#6211
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR IntersectMBO/ouroboros-consensus#1288 has introduced the
HeaderWithTimedatatype which annotates block headers with their slot'sRelativeTime.This PR ensures the tracing system is modified to effectively ignore
HeaderWithTimebydropping the time annotations and using the underlying
Header, keeping the current tracing behaviour unchanged.Checklist
See Runnings tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-9.6andghc-9.12Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.