Respect aspect ratio of image on large displays#107
Open
mattharcourt wants to merge 5 commits intoIsaacGemal:mainfrom
Open
Respect aspect ratio of image on large displays#107mattharcourt wants to merge 5 commits intoIsaacGemal:mainfrom
mattharcourt wants to merge 5 commits intoIsaacGemal:mainfrom
Conversation
…que version of the image expanded to fill the display.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's an alternative to #69
Here's a version where, for large displays only, the thumbnail image is displayed at it's original aspect ratio, but inset over a semi-opaque version of the thumbnail stretched to fill the display.
See if this is a more interesting and acceptable background at the edges.