Skip to content

Respect aspect ratio of image on large displays #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattharcourt wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Respect aspect ratio of image on large displays #107

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6f53dae
For large screens: display image at original aspect ratio over an opa…
mattharcourt Feb 10, 2025
5c16e94
Merge branch 'IsaacGemal:main' into respect-image-aspect-ratio-on-des…
mattharcourt Mar 3, 2025
edde319
Merge branch 'IsaacGemal:main' into respect-image-aspect-ratio-on-des…
mattharcourt Mar 4, 2025
60648f8
Merge branch 'IsaacGemal:main' into respect-image-aspect-ratio-on-des…
mattharcourt Mar 15, 2025
d960bd2
Merge branch 'IsaacGemal:main' into respect-image-aspect-ratio-on-des…
mattharcourt Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions frontend/src/components/WikiCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,18 @@ export function WikiCard({ article }: WikiCardProps) {

return (
<div className="h-screen w-full flex items-center justify-center snap-start relative" onDoubleClick={() => toggleLike(article)}>
<div className="h-full w-full relative">
<div className="h-full w-full relative bg-white">
{article.thumbnail ? (
<div className="absolute inset-0">
<div
style={{ '--bg-image': `url('${article.thumbnail.source}')` }}
className={`absolute inset-0 lg:bg-cover lg:bg-[image:var(--bg-image)]`}
>
<div className="absolute inset-0 lg:bg-black lg:opacity-50"/>
<img
loading="lazy"
src={article.thumbnail.source}
alt={article.displaytitle}
className={`w-full h-full object-cover transition-opacity duration-300 bg-white ${imageLoaded ? 'opacity-100' : 'opacity-0'
className={`w-full h-full lg:relative lg:inset-1/20 lg:w-9/10 lg:h-9/10 object-cover lg:object-contain transition-opacity duration-300 bg-white lg:bg-transparent ${imageLoaded ? 'opacity-100' : 'opacity-0'
}`}
onLoad={() => setImageLoaded(true)}
onError={(e) => {
Expand Down