Skip to content

Comments

[minor] add grok processor to cantaloupe#420

Merged
nigelgbanks merged 2 commits intomainfrom
grok
May 6, 2025
Merged

[minor] add grok processor to cantaloupe#420
nigelgbanks merged 2 commits intomainfrom
grok

Conversation

@joecorall
Copy link
Contributor

No description provided.

@joecorall joecorall marked this pull request as ready for review April 30, 2025 15:07
@joecorall
Copy link
Contributor Author

qemu must be slowing down this build. On my local arm machine it only takes like 5-10 min to build this. Gotta rethink this

@joecorall joecorall marked this pull request as draft April 30, 2025 16:04
@nigelgbanks
Copy link
Contributor

qemu must be slowing down this build. On my local arm machine it only takes like 5-10 min to build this. Gotta rethink this

Yup, compiling under emulation is terribly slow, nodejs also takes >1hr. We can move this into a separate repo and package it in the same way we do for ImageMagick, etc.

Do you want me to take the code you have here and setup a repo an APK package for it?

@nigelgbanks
Copy link
Contributor

At some point I would like to use cross compilation for all the tooling, just haven't had the time as of late.

@joecorall
Copy link
Contributor Author

At some point I would like to use cross compilation for all the tooling, just haven't had the time as of late.

Hmm so if we replaced qemu with instead running the docker builds on separate arm and amd64 github actions runners, have the platform-specific builds push to docker hub with a platform tag, then ran a new GHA job that stitches the cross-platform manifest as our main tag from the two platform-specific images we could have this PR use this new approach, and perhaps we could build everything in this repo instead of the separate nodejs/imagemagick/leptonica repos we have?

@nigelgbanks
Copy link
Contributor

Definitely that would be the case.

I mentioned a re-write I was working on, like 2 months back. I still have the work locally, just not the time to put into it, though hopefully that will change in the next few days.

This was something I wanted to do on Digital Ocean, since the foundation already has an account there, and we could do it for cheap. Turns out they don't have ARM backed servers, so we'd pretty much have to do this on AWS. So we'll need to do some convincing for the foundation to set up an account and to approve the costs. Though I'm sure we can do if for like 10-20 a month, likely less.

@nigelgbanks
Copy link
Contributor

@nigelgbanks
Copy link
Contributor

Ah we might be able to do this for free :D

@joecorall joecorall marked this pull request as ready for review May 6, 2025 14:46
@nigelgbanks nigelgbanks merged commit 5c97844 into main May 6, 2025
122 checks passed
@nigelgbanks nigelgbanks deleted the grok branch May 6, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants