-
Notifications
You must be signed in to change notification settings - Fork 35
[MOB-11175] make-rn-sdk-compatible-with-expo #629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lposen
merged 15 commits into
master
from
expo/MOB-11175-make-rn-sdk-compatible-with-expo
Apr 10, 2025
Merged
Changes from 12 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
11174ca
refactor: remove the RNIterableAPI module and updating imports across…
lposen eecd501
refactor: initialize `inAppContent` to null instead of an empty class…
lposen 440b326
refactor: remove RNIterableAPI export from index.ts
lposen f87662d
refactor: adjust logging to use optional chaining for safety, as othe…
lposen 32da43e
chore: update version in package.json to 2.0.0-beta
lposen 5c6da49
refactor: update logging to use optional chaining for safety in Itera…
lposen 7aecec5
refactor: formatted code
lposen 00ee6ad
chore: update react native builder bob
lposen 525eab2
refactor: remove Iterable.inAppManager and update imports to resolve …
lposen 449c68d
docs: fix linter issues
lposen 392b51a
refactor: resolve circular dependencies
lposen 2ed58ad
Concurrent Ruby version
f935077
chore: update Gemfile and README for Ruby 3.4.0 compatibility and adj…
lposen ae85bdb
Merge branch 'expo/MOB-11175-make-rn-sdk-compatible-with-expo' of git…
lposen bf51fd5
chore: enable pre-commit hooks for linting and type checking with ESL…
lposen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
v18 | ||
v20.19.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,3 @@ | ||
module.exports = { | ||
presets: [ | ||
['module:react-native-builder-bob/babel-preset', { modules: 'commonjs' }], | ||
], | ||
presets: ['module:react-native-builder-bob/babel-preset'], | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,3 +6,4 @@ ruby ">= 2.6.10" | |
# Exclude problematic versions of cocoapods and activesupport that causes build failures. | ||
gem 'cocoapods', '>= 1.13', '!= 1.15.0', '!= 1.15.1' | ||
gem 'activesupport', '>= 6.1.7.5', '!= 7.1.0' | ||
gem 'concurrent-ruby', '< 1.3.4' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected a newline at the end of the file.