[MOB-11175] make-rn-sdk-compatible-with-expo #629

lposen · 2025-04-07T21:12:45Z

🔹 JIRA Ticket(s) if any

MOB-11175

✏️ Description

Fixes issues that cause expo builds to fail

Test

Just run the example app and make sure that everything loads as expected. None of the changes are high risk, so a quick smoke check is fine.

… multiple files to use NativeModules directly, as expo does breaks when importing this from another file

…, as the empty class was breaking expo

…rwise there appears to be an error in expo

…bleInAppManager and IterableInboxDataModel, otherwise expo gets upset

github-actions · 2025-04-07T21:13:54Z

Lines	Statements	Branches	Functions
	38.11% (178/467)	11.29% (20/177)	32.46% (50/154)

Copilot

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

codeclimate · 2025-04-07T21:14:40Z

❌ 3 blocking issues (4 total)

Tool	Category	Rule	Count
rubocop	Lint	Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem `concurrent\-ruby` should appear before `xcodeproj`.	2	❌
prettier	Style	Incorrect formatting, autoformat by running `qlty fmt`.	1	❌
ripgrep	Lint	// TODO: Organize these so that there are no circular dependencies	1

@qltysh one-click actions:

Auto-fix formatting (qlty fmt && git push)

_{This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.}

codeclimate · 2025-04-07T21:26:15Z

src/inApp/classes/IterableInAppManager.ts

+import { NativeModules } from 'react-native';
+
+import { Iterable } from '../../core';
+import type { IterableInAppDeleteSource, IterableInAppLocation } from '../enums';


unused expression, expected an assignment or function call

codeclimate · 2025-04-07T21:26:15Z

src/inApp/classes/IterableInAppManager.ts

+import { NativeModules } from 'react-native';
+
+import { Iterable } from '../../core';
+import type { IterableInAppDeleteSource, IterableInAppLocation } from '../enums';


Do not use comma operator here because it can be easily misunderstood or lead to unintended bugs.

codeclimate · 2025-04-07T21:26:15Z

src/inbox/classes/IterableInboxDataModel.ts

-  IterableInboxImpressionRowInfo,
-  IterableInboxRowViewModel,
-} from '../types';
+import type { IterableInboxImpressionRowInfo, IterableInboxRowViewModel } from '../types';


unused expression, expected an assignment or function call

codeclimate · 2025-04-07T21:26:15Z

src/inbox/classes/IterableInboxDataModel.ts

-  IterableInboxImpressionRowInfo,
-  IterableInboxRowViewModel,
-} from '../types';
+import type { IterableInboxImpressionRowInfo, IterableInboxRowViewModel } from '../types';


Do not use comma operator here because it can be easily misunderstood or lead to unintended bugs.

…circular dependencies

codeclimate · 2025-04-09T19:02:55Z

src/core/classes/Iterable.ts

-  IterableInAppManager,
-  IterableInAppMessage,
-} from '../../inApp';
+// TODO: Organize these so that there are no circular dependencies


codeclimate · 2025-04-09T19:02:55Z

src/inApp/types/IterableHtmlInAppContentRaw.ts

+// expo throws an error if this is not imported directly due to circular
+// dependencies
+// See https://github.com/expo/expo/issues/35100
+import type { IterableEdgeInsetDetails } from '../../core/types/IterableEdgeInsetDetails';


unused expression, expected an assignment or function call

codeclimate · 2025-04-09T19:02:55Z

src/inApp/types/IterableInAppContent.ts

+// expo throws an error if this is not imported directly due to circular
+// dependencies
+// See https://github.com/expo/expo/issues/35100
+import type { IterableInAppContentType } from '../enums/IterableInAppContentType';


unused expression, expected an assignment or function call

codeclimate · 2025-04-09T19:04:19Z

src/core/classes/Iterable.ts

-  IterableInAppManager,
-  IterableInAppMessage,
-} from '../../inApp';
+// TODO: Organize these so that there are no circular dependencies


// TODO: Organize these so that there are no circular dependencies [ripgrep:TODO]

codeclimate · 2025-04-10T00:12:25Z

example/Gemfile

@@ -6,3 +6,4 @@ ruby ">= 2.6.10"
 # Exclude problematic versions of cocoapods and activesupport that causes build failures.
 gem 'cocoapods', '>= 1.13', '!= 1.15.0', '!= 1.15.1'
 gem 'activesupport', '>= 6.1.7.5', '!= 7.1.0'
+gem 'concurrent-ruby', '< 1.3.4'


Expected a newline at the end of the file.

codeclimate · 2025-04-10T00:13:25Z

example/Gemfile

@@ -6,3 +6,4 @@ ruby ">= 2.6.10"
 # Exclude problematic versions of cocoapods and activesupport that causes build failures.
 gem 'cocoapods', '>= 1.13', '!= 1.15.0', '!= 1.15.1'
 gem 'activesupport', '>= 6.1.7.5', '!= 7.1.0'
+gem 'concurrent-ruby', '< 1.3.4'


Final newline missing. [rubocop:Layout/TrailingEmptyLines]

codeclimate · 2025-04-10T00:13:25Z

src/core/classes/Iterable.ts

-  IterableInAppManager,
-  IterableInAppMessage,
-} from '../../inApp';
+// TODO: Organize these so that there are no circular dependencies


// TODO: Organize these so that there are no circular dependencies [ripgrep:TODO]

…ust package version

…hub.com:Iterable/react-native-sdk into expo/MOB-11175-make-rn-sdk-compatible-with-expo * 'expo/MOB-11175-make-rn-sdk-compatible-with-expo' of github.com:Iterable/react-native-sdk: Concurrent Ruby version

…int and TypeScript

Ayyanchira

Looks good. Only caveat is Xcode 16.2.

codeclimate · 2025-04-10T00:46:00Z

Code Climate has analyzed commit bf51fd5 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Bug Risk	1
Style	2

The test coverage on the diff in this pull request is 71.1% (50% is the threshold).

This pull request will bring the total coverage in the repository to 38.4% (0.5% change).

View more on Code Climate.

codeclimate · 2025-04-10T00:46:58Z

example/Gemfile

@@ -6,3 +6,11 @@ ruby ">= 2.6.10"
 # Exclude problematic versions of cocoapods and activesupport that causes build failures.
 gem 'cocoapods', '>= 1.13', '!= 1.15.0', '!= 1.15.1'
 gem 'activesupport', '>= 6.1.7.5', '!= 7.1.0'
+gem 'xcodeproj', '< 1.26.0'
+gem 'concurrent-ruby', '< 1.3.4'


Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem concurrent-ruby should appear before xcodeproj. [rubocop:Bundler/OrderedGems]

codeclimate · 2025-04-10T00:46:58Z

example/Gemfile

+# Ruby 3.4.0 has removed some libraries from the standard library.
+gem 'bigdecimal'
+gem 'logger'
+gem 'benchmark'


Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem benchmark should appear before logger. [rubocop:Bundler/OrderedGems]

codeclimate · 2025-04-10T00:46:59Z

src/core/classes/Iterable.ts

-  IterableInAppManager,
-  IterableInAppMessage,
-} from '../../inApp';
+// TODO: Organize these so that there are no circular dependencies


// TODO: Organize these so that there are no circular dependencies [ripgrep:TODO]

lposen added 6 commits April 7, 2025 13:46

refactor: remove the RNIterableAPI module and updating imports across…

11174ca

… multiple files to use NativeModules directly, as expo does breaks when importing this from another file

refactor: initialize inAppContent to null instead of an empty class…

eecd501

…, as the empty class was breaking expo

refactor: remove RNIterableAPI export from index.ts

440b326

refactor: adjust logging to use optional chaining for safety, as othe…

f87662d

…rwise there appears to be an error in expo

chore: update version in package.json to 2.0.0-beta

32da43e

refactor: update logging to use optional chaining for safety in Itera…

5c6da49

…bleInAppManager and IterableInboxDataModel, otherwise expo gets upset

lposen requested a review from Copilot April 7, 2025 21:14

Copilot AI reviewed Apr 7, 2025

View reviewed changes

refactor: formatted code

7aecec5

codeclimate bot reviewed Apr 7, 2025

View reviewed changes

lposen added 4 commits April 9, 2025 10:59

chore: update react native builder bob

00ee6ad

refactor: remove Iterable.inAppManager and update imports to resolve …

525eab2

…circular dependencies

docs: fix linter issues

449c68d

refactor: resolve circular dependencies

392b51a

codeclimate bot reviewed Apr 9, 2025

View reviewed changes

Concurrent Ruby version

2ed58ad

codeclimate bot reviewed Apr 10, 2025

View reviewed changes

lposen added 2 commits April 9, 2025 17:40

chore: update Gemfile and README for Ruby 3.4.0 compatibility and adj…

f935077

…ust package version

Merge branch 'expo/MOB-11175-make-rn-sdk-compatible-with-expo' of git…

ae85bdb

…hub.com:Iterable/react-native-sdk into expo/MOB-11175-make-rn-sdk-compatible-with-expo * 'expo/MOB-11175-make-rn-sdk-compatible-with-expo' of github.com:Iterable/react-native-sdk: Concurrent Ruby version

Ayyanchira self-requested a review April 10, 2025 00:43

chore: enable pre-commit hooks for linting and type checking with ESL…

bf51fd5

…int and TypeScript

Ayyanchira approved these changes Apr 10, 2025

View reviewed changes

codeclimate bot reviewed Apr 10, 2025

View reviewed changes

lposen merged commit 63ec450 into master Apr 10, 2025
10 of 11 checks passed

lposen deleted the expo/MOB-11175-make-rn-sdk-compatible-with-expo branch April 10, 2025 00:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MOB-11175] make-rn-sdk-compatible-with-expo #629

[MOB-11175] make-rn-sdk-compatible-with-expo #629

lposen commented Apr 7, 2025 •

edited

Loading

github-actions bot commented Apr 7, 2025 •

edited

Loading

Copilot AI left a comment

codeclimate bot commented Apr 7, 2025 •

edited

Loading

codeclimate bot Apr 7, 2025

codeclimate bot Apr 7, 2025

codeclimate bot Apr 7, 2025

codeclimate bot Apr 7, 2025

codeclimate bot Apr 9, 2025

codeclimate bot Apr 9, 2025

codeclimate bot Apr 9, 2025

codeclimate bot Apr 9, 2025

codeclimate bot Apr 10, 2025

codeclimate bot Apr 10, 2025

codeclimate bot Apr 10, 2025

Ayyanchira left a comment

codeclimate bot commented Apr 10, 2025

codeclimate bot Apr 10, 2025

codeclimate bot Apr 10, 2025

codeclimate bot Apr 10, 2025

[MOB-11175] make-rn-sdk-compatible-with-expo #629

[MOB-11175] make-rn-sdk-compatible-with-expo #629

Conversation

lposen commented Apr 7, 2025 • edited Loading

🔹 JIRA Ticket(s) if any

✏️ Description

Test

github-actions bot commented Apr 7, 2025 • edited Loading

Copilot AI left a comment

Choose a reason for hiding this comment

codeclimate bot commented Apr 7, 2025 • edited Loading

❌ 3 blocking issues (4 total)

codeclimate bot Apr 7, 2025

Choose a reason for hiding this comment

codeclimate bot Apr 7, 2025

Choose a reason for hiding this comment

codeclimate bot Apr 7, 2025

Choose a reason for hiding this comment

codeclimate bot Apr 7, 2025

Choose a reason for hiding this comment

codeclimate bot Apr 9, 2025

Choose a reason for hiding this comment

codeclimate bot Apr 9, 2025

Choose a reason for hiding this comment

codeclimate bot Apr 9, 2025

Choose a reason for hiding this comment

codeclimate bot Apr 9, 2025

Choose a reason for hiding this comment

codeclimate bot Apr 10, 2025

Choose a reason for hiding this comment

codeclimate bot Apr 10, 2025

Choose a reason for hiding this comment

codeclimate bot Apr 10, 2025

Choose a reason for hiding this comment

Ayyanchira left a comment

Choose a reason for hiding this comment

codeclimate bot commented Apr 10, 2025

codeclimate bot Apr 10, 2025

Choose a reason for hiding this comment

codeclimate bot Apr 10, 2025

Choose a reason for hiding this comment

codeclimate bot Apr 10, 2025

Choose a reason for hiding this comment

lposen commented Apr 7, 2025 •

edited

Loading

github-actions bot commented Apr 7, 2025 •

edited

Loading

codeclimate bot commented Apr 7, 2025 •

edited

Loading