[WIP] Fix database sync by koppor · Pull Request #11879 · JabRef/jabref

koppor · 2024-10-03T21:42:47Z

Improves the NOTIFY and LISTEN for PostgreSQL database (to get content)

Removes MySQL/MariaDB and Oracle support (due to high maintenance effort).

Open points:

finish ^^
Include idea of Draft for fixing sync with groups and shared db #11314

Mandatory checks

Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for UI changes)
Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Co-authored-by: Christoph <siedlerkiller@gmail.com>

github-actions

Your code currently does not meet JabRef's code guidelines.
We use Checkstyle to identify issues.
The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR.
Please carefully follow the setup guide for the codestyle.
Afterwards, please run checkstyle locally and fix the issues.

You can check review dog's comments at the tab "Files changed" of your pull request.

- try to simplify SQL statements - create indexes

src/main/java/org/jabref/logic/shared/PostgreSQLProcessor.java

github-actions

You modified Markdown (*.md) files and did not meet JabRef's rules for consistently formatted Markdown files.
To ensure consistent styling, we have markdown-lint in place.
Markdown lint's rules help to keep our Markdown files consistent within this repository and consistent with the Markdown files outside here.

You can check the detailed error output by navigating to your pull request, selecting the tab "Checks", section "Tests" (on the left), subsection "Markdown".

github-actions · 2024-10-09T06:04:36Z

src/main/java/org/jabref/logic/shared/notifications/FieldChange.java

+        String bibEntryId,
+        String field,
+        String oldValue,
+        String newValue) {}


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> _{reported by reviewdog 🐶}
'{' is not followed by whitespace.

github-actions · 2024-10-09T06:04:36Z

src/main/java/org/jabref/logic/shared/notifications/Notifier.java

+import com.google.gson.Gson;
+import com.google.gson.GsonBuilder;
+
+import org.jabref.model.entry.event.FieldChangedEvent;


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.ImportOrderCheck> _{reported by reviewdog 🐶}
Wrong order for 'org.jabref.model.entry.event.FieldChangedEvent' import.

github-actions · 2024-10-09T06:04:36Z

src/main/java/org/jabref/logic/shared/notifications/Notifier.java

+import com.google.gson.GsonBuilder;
+
+import org.jabref.model.entry.event.FieldChangedEvent;
+import org.postgresql.PGConnection;


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.ImportOrderCheck> _{reported by reviewdog 🐶}
'org.postgresql.PGConnection' should be separated from previous imports.

# Conflicts: # src/main/java/org/jabref/gui/shared/SharedDatabaseUIManager.java

# Conflicts: # build.gradle # src/main/java/module-info.java # src/main/java/org/jabref/logic/shared/notifications/NotificationListener.java

# Conflicts: # build.gradle # src/main/java/org/jabref/logic/shared/notifications/NotificationListener.java # src/main/java/org/jabref/model/entry/event/FieldChangedEvent.java

github-actions · 2025-03-16T22:34:26Z

The build of this PR is available at https://builds.jabref.org/pull/11879/merge.

InAnYan · 2025-12-29T14:36:33Z

I think I'll convert to draft, as there is a lot of work to be done

github-actions · 2026-01-28T03:39:30Z

Your pull request conflicts with the target branch.

Please merge with your code. For a step-by-step guide to resolve merge conflicts, see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-using-the-command-line.

koppor and others added 10 commits October 3, 2024 22:22

Refactor method signature

443765f

Co-authored-by: Christoph <siedlerkiller@gmail.com>

Rename maps

f3921c2

Co-authored-by: Christoph <siedlerkiller@gmail.com>

Cleanup EntriesAddedEvent

92a2287

Co-authored-by: Christoph <siedlerkiller@gmail.com>

Clean up EntriesRemovedEvent

f0465a6

Co-authored-by: Christoph <siedlerkiller@gmail.com>

Disable save actions for SQL

95fe7f6

Co-authored-by: Christoph <siedlerkiller@gmail.com>

Fix logger string

279da5b

Add TODO

e19bc1a

Co-authored-by: Christoph <siedlerkiller@gmail.com>

Remove MySQL and Oracle dependencies

90e067d

Co-authored-by: Christoph <siedlerkiller@gmail.com>

Remove PullChangesFromSharedAction

35d6411

Co-authored-by: Christoph <siedlerkiller@gmail.com>

Improve doc and code comments

f4f40c6

Co-authored-by: Christoph <siedlerkiller@gmail.com>

koppor added this to the 6.0-beta milestone Oct 3, 2024

github-actions bot reviewed Oct 3, 2024

View reviewed changes

koppor and others added 15 commits October 4, 2024 14:03

Mark variable to be removed

7e459be

Fix class name

f901151

Introduce BibEntry.ENTRY_LINK_SEPARATOR

f6a2fe5

Cleanup code in CitationKeyListener

8a11cb9

More Java 8

fd958b6

Minor code updates

fd7697b

Begin: separate metadata sync with all-entry-sync

770cef0

Use "ON CONFLICT" of PostgreSQL

2c8faa7

Remove non-used get

dcf605f

Fix language

55bb387

Fix module-info.java

fd3c184

Switch from "external" Postgres to embedded Postgres

5c863dc

Remove escape and escape_Table (and add indexes)

7e0ba3e

- try to simplify SQL statements - create indexes

Fix method name "isFiltered" and also link reasoning

407b307

Merge branch 'main' into fix-sync

f19101b

Siedlerchr reviewed Oct 4, 2024

View reviewed changes

src/main/java/org/jabref/logic/shared/PostgreSQLProcessor.java Outdated Show resolved Hide resolved

github-actions bot reviewed Oct 4, 2024

View reviewed changes

Integrate PostgreSQLProcessor in DBMSProcessor

5a36849

github-actions bot reviewed Oct 9, 2024

View reviewed changes

This comment was marked as outdated.

Sign in to view

koppor added 2 commits October 9, 2024 22:58

Merge branch 'main' into fix-sync

e4c7130

Fix compile error (and typo)

598d83e

This comment was marked as outdated.

Sign in to view

koppor added 5 commits October 10, 2024 08:30

Add databaseName as parameter

a78afc9

Compilefix

7eb4b07

Merge branch 'fix-sync' of github.com:JabRef/jabref into fix-sync

a9a2708

# Conflicts: # src/main/java/org/jabref/gui/shared/SharedDatabaseUIManager.java

Remove unnecessary JavaDoc

bc68c19

Fix tests

dd64830

This comment was marked as outdated.

Sign in to view

koppor added 2 commits November 7, 2024 12:50

Merge branch 'main' into fix-sync

801acdf

# Conflicts: # build.gradle # src/main/java/module-info.java # src/main/java/org/jabref/logic/shared/notifications/NotificationListener.java

Compile fix

1b896d0

koppor self-assigned this Nov 11, 2024

Merge branch 'main' into fix-sync

2dd2beb

koppor mentioned this pull request Feb 16, 2025

WIP: Dbsync performance improvements #8496

Closed

5 tasks

koppor added 5 commits February 16, 2025 21:24

Merge remote-tracking branch 'origin/main' into fix-sync

8266ee2

# Conflicts: # build.gradle # src/main/java/org/jabref/logic/shared/notifications/NotificationListener.java # src/main/java/org/jabref/model/entry/event/FieldChangedEvent.java

Fix style issues (and add JavaDoc comment from review comments)=

6ad0eb6

Fix CHANGELOG.md

e7decae

Small comments

4dbce0b

Merge branch 'main' into fix-sync

4ee8fe5

koppor mentioned this pull request Nov 21, 2025

Clean up unused code in BibEntry class #14377

Merged

1 task

koppor added the 📌 Pinned label Dec 2, 2025

koppor mentioned this pull request Dec 4, 2025

METADATA Table - Structure Update with JSON #14506

Open

calixtus added the component: collaboration label Dec 12, 2025

InAnYan marked this pull request as draft December 29, 2025 14:36

github-actions bot added the status: changes-required Pull requests that are not yet complete label Jan 28, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[WIP] Fix database sync#11879

[WIP] Fix database sync#11879
koppor wants to merge 62 commits intomainfrom
fix-sync

koppor commented Oct 3, 2024 •

edited

Loading

Uh oh!

github-actions bot left a comment

Uh oh!

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot Oct 9, 2024

Uh oh!

github-actions bot Oct 9, 2024

Uh oh!

github-actions bot Oct 9, 2024

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions bot commented Mar 16, 2025

Uh oh!

InAnYan commented Dec 29, 2025

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

koppor commented Oct 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Mandatory checks

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 9, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 9, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 9, 2024

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions bot commented Mar 16, 2025

Uh oh!

InAnYan commented Dec 29, 2025

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

koppor commented Oct 3, 2024 •

edited

Loading