Skip to content

fix langchain module errors#13853

Merged
Siedlerchr merged 10 commits intomainfrom
modules
Sep 11, 2025
Merged

fix langchain module errors#13853
Siedlerchr merged 10 commits intomainfrom
modules

Conversation

@Siedlerchr
Copy link
Copy Markdown
Member

@Siedlerchr Siedlerchr commented Sep 11, 2025 •
edited
Loading

Closes #13849

Steps to test

Add an entry with a pdf
Add an api key for geminin the preferences
Go to AI chat or AI summary
=> No exception

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • I manually tested my changes in running JabRef (always required)
  • [.] I added JUnit tests for changes (if applicable)
  • [.] I added screenshots in the PR description (if change is visible to the user)
  • [.] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [.] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

@Siedlerchr
fix git modules requires and uses
b6451f1
@Siedlerchr
Merge remote-tracking branch 'upstream/main'
9bee24f 
* upstream/main:
  New translations jabref_en.properties (Italian) (#13725)
  Minor code style updates (#13722)
  Fix: Make FileUtil.relativize symlink-aware (#13553)
  New Crowdin updates (#13720)
  Bump org.glassfish.jersey.core:jersey-server in /versions (#13714)
  Enable UseObjectNotifyAll (#13718)
  Bump com.dlsc.gemsfx:gemsfx from 3.3.5 to 3.4.2 in /versions (#13717)
  Update on-issue-comment.yml
  Bump org.openrewrite.recipe:rewrite-recipe-bom from 3.12.1 to 3.13.0 (#13716)
  Bump org.openrewrite.rewrite from 7.12.1 to 7.14.0 (#13715)
  Bump org.glassfish.jersey.inject:jersey-hk2 in /versions (#13713)
  feat(git): add “Share to GitHub” flow (#13677)
  Bump jablib/src/main/resources/csl-styles from `292aec3` to `1194364` (#13712)
  Bump jablib/src/main/abbrv.jabref.org from `cfe719f` to `a97f9c6` (#13711)
  Bump jablib/src/main/resources/csl-locales from `e2de1e3` to `fa56de1` (#13710)
  Add noop Git Config System Reader to prevent usage of real world stuff into jgit (#13703)
  Added static (stream & preferences) constructors to BibDatabaseContext (#13694)
  New Crowdin updates (#13698)
  fix git modules requires and uses (#13696)
  Focus "Specify Bib(La)TeX" when Bib(La)TeX is in clipboard (#13633)
@Siedlerchr
Merge remote-tracking branch 'upstream/main'
c0d0a7c 
* upstream/main: (32 commits)
  Fix path (#13769)
  Mode aware consistency check (#13584)
  Refine JBang check (#13765)
  Add Language Server to the UI and add the integrity/consistency check (#13697)
  Fix/remove comment code (#13763)
  New Crowdin updates (#13760)
  Bump org.openrewrite.rewrite from 7.14.0 to 7.14.1 (#13757)
  Bump com.autonomousapps:dependency-analysis-gradle-plugin (#13756)
  Bump dev.langchain4j:langchain4j-bom from 1.2.0 to 1.3.0 in /versions (#13755)
  Bump jablib/src/main/resources/csl-locales from `fa56de1` to `e29c453` (#13754)
  Bump com.autonomousapps:dependency-analysis-gradle-plugin (#13753)
  Bump org.mockito:mockito-core from 5.18.0 to 5.19.0 in /versions (#13752)
  Bump actions/upload-pages-artifact from 3 to 4 (#13751)
  Migrate fetchers to Search.g4 ANTLR parser. (#13691)
  [Junie]: fix: resolve IllegalArgumentException for non-absolute URIs (#13669)
  Add auto-renaming of linked files on entry data change (#13295)
  Walkthrough additions (#13745)
  Switch from zulu to corretto (#13749)
  New Crowdin updates (#13747)
  Fix copy to (#13741)
  ...
@Siedlerchr
Merge remote-tracking branch 'upstream/main'
2c4d427 
* upstream/main:
  Add missing variables
  Reformat BibTex in Show BibTex Source (#13761)
  Auto publish before JBang tests (#13779)
  Hotfix: calling of publish.yml
  Support BibLaTeX datamodel validations (#13693)
  Auto add and remove of "status: changes-required" label (#13778)
  New Crowdin updates (#13777)
  Restore local-only Git behavior for SLR to fix repository initialization error (#13775)
  Use vanilla hashset (#13771)
  Fix Springer Fetcher names (#13770)
  Fix condition
  Publish SNAPSHOT on jablib change (#13774)
  Adapt as per new set of checks (#13772)
  Bump jablib/src/main/resources/csl-styles from `1194364` to `17cfa60` (#13750)
@Siedlerchr
Merge remote-tracking branch 'upstream/main'
5277005 
* upstream/main: (54 commits)
  Split relativizeSymlinks parameterized tests in separate tests (#13782)
  Update the search syntax highlight for web search (#13801)
  Chore(deps): Bump ai.djl:bom from 0.33.0 to 0.34.0 in /versions (#13833)
  Fix typos in CHANGELOG.md (#13826)
  Chore(deps): Bump com.konghq:unirest-modules-gson in /versions (#13831)
  Chore(deps): Bump org.gradlex:extra-java-module-info in /build-logic (#13830)
  Chore(deps): Bump org.apache.logging.log4j:log4j-to-slf4j in /versions (#13832)
  Chore(deps): Bump io.zonky.test.postgres:embedded-postgres-binaries-bom (#13834)
  Chore(deps): Bump jablib/src/main/resources/csl-locales (#13829)
  Chore(deps): Bump jablib/src/main/resources/csl-styles (#13827)
  Chore(deps): Bump jablib/src/main/abbrv.jabref.org (#13828)
  add: CAYW endpoint formats (#13785)
  New Crowdin updates (#13823)
  chore(deps): update dependency org.kohsuke:github-api to v2.0-rc.5 (#13822)
  Add support for automatic ICORE conference ranking lookup [#13476] (#13699)
  New Crowdin updates (#13820)
  Initialize search bar auto-completion with real database context (no tab switch needed) (#13816)
  Fixes #13274: Allow cygwin-paths on Windows (#13297)
  Refine "REDACTED" replacement of API key value in web fetcher search URL (#13814)
  changed ISSNCleanup into NormalizeIssn, refactored respective tests #13748 (#13767)
  ...
@Siedlerchr
Merge remote-tracking branch 'upstream/main'
511549f 
* upstream/main:
  Fix typo in PR template
  Fix: No exception if file is not within a git repository (#13839)
  Fix lsp4j modules (#13835)
  New Crowdin updates (#13837)
@Siedlerchr
Merge remote-tracking branch 'upstream/main'
2a819aa 
* upstream/main:
  Fix NoSuchElementException in ThreeWayMerge dialog (#13838)
  Keep global search bar open when  keep on top pin is selected (#13846)
  Spell "BibDesk" with capital "D" (#13847)
  fix: Improper icon sizing with respect to font size (#13841)
  Ensure latest JDK veriant (#13843)
@Siedlerchr
test with uses to fix langchain4j error
a6461b4
@Siedlerchr
try to fix moduöes
c47ba9f
@Siedlerchr Siedlerchr mentioned this pull request Sep 11, 2025
Closed
2 tasks
@trag-bot
Copy link
Copy Markdown

trag-bot bot commented Sep 11, 2025

@trag-bot didn't find any issues in the code! ✅✨

@Siedlerchr Siedlerchr changed the title test with langchain 4j module errors fix langchain module errors Sep 11, 2025
@Siedlerchr Siedlerchr added the dev: binaries Binary builds should be uploaded to builds.jabref.org label Sep 11, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 11, 2025

The build of this PR is available at https://builds.jabref.org/pull/13853/merge.

@Siedlerchr
Copy link
Copy Markdown
Member Author

Siedlerchr commented Sep 11, 2025

test binaries, work

@Siedlerchr Siedlerchr added this pull request to the merge queue Sep 11, 2025
@Siedlerchr Siedlerchr removed this pull request from the merge queue due to a manual request Sep 11, 2025
@Siedlerchr Siedlerchr added this pull request to the merge queue Sep 11, 2025
github-merge-queue bot pushed a commit that referenced this pull request Sep 11, 2025
@Siedlerchr
fix langchain module errors (#13853)
fa36ab7 
* fix git modules requires and uses

* test with uses to fix langchain4j error

* try to fix moduöes

* Fix modules
@Siedlerchr Siedlerchr removed this pull request from the merge queue due to a manual request Sep 11, 2025
@Siedlerchr Siedlerchr added this pull request to the merge queue Sep 11, 2025
Merged via the queue into main with commit 614633b Sep 11, 2025
49 of 56 checks passed
@Siedlerchr Siedlerchr deleted the modules branch September 11, 2025 20:09
Siedlerchr added a commit that referenced this pull request Sep 11, 2025
@Siedlerchr
Merge remote-tracking branch 'upstream/main'
aa1818f 
* upstream/main:
  fix langchain module errors (#13853)
  Enhance PR validation actions (#13850)
@ugoloc
Copy link
Copy Markdown

ugoloc commented Sep 18, 2025

Thanks for fixing this. As soon as the Windows binary gets updated in https://builds.jabref.org/main/ I can give a feedback on the fix.

@Siedlerchr
Copy link
Copy Markdown
Member Author

Siedlerchr commented Sep 18, 2025

That should already be the case. The binaries are built automatically after a merge

@ugoloc
Copy link
Copy Markdown

ugoloc commented Sep 18, 2025

Maybe I'm missing something, but I still see the old version of windows files, while MacOS, Debian, etc. are updated.

image

@Siedlerchr
Copy link
Copy Markdown
Member Author

Siedlerchr commented Sep 18, 2025

@koppor is this related to the failing windows test that no binaries are built?

@koppor
Copy link
Copy Markdown
Member

koppor commented Sep 18, 2025

@koppor is this related to the failing windows test that no binaries are built?

I am on the mobile phone with limited browser access. Do you have any links?

Normally, binaries are built independent of tests.

@Siedlerchr
Copy link
Copy Markdown
Member Author

Siedlerchr commented Sep 23, 2025

@ugoloc Upload of windows binaries is working again!

@ugoloc
Copy link
Copy Markdown

ugoloc commented Sep 25, 2025

Thanks! I can confirm that the langchain bug is fixed on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koppor koppor koppor approved these changes

Assignees

No one assigned

Labels

dev: binaries Binary builds should be uploaded to builds.jabref.org

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AI functions, module langchain4j.core does not declare uses

3 participants

@Siedlerchr @ugoloc @koppor