Skip to content

fix(terra-draw): call cleanup when a currently drawn feature is deleted #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
JamesLMilner wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

fix(terra-draw): call cleanup when a currently drawn feature is deleted #760

JamesLMilner wants to merge 8 commits into from

Conversation

@JamesLMilner
Copy link
Owner

@JamesLMilner JamesLMilner commented Dec 28, 2025 •
edited
Loading

Description of Changes

  • When calling removeFeatures, if a currently drawn feature is present, call cleanUp for that mode so that the drawing state is reset correctly
  • For all built in modes, avoid using try and instead wrap all deletes in cleanUp in a check to ensure that the feature is still present in the store

Link to Issue

#758

PR Checklist

  • The PR title follows the conventional commit standard
  • There is a associated GitHub issue
  • If I have added significant code changes, there are relevant tests
  • If there are behaviour changes these are documented

@JamesLMilner JamesLMilner changed the title test(terra-draw): add unit tests to ensure on finish behavior works as expected fix(terra-draw): call cleanup when a currently drawn feature is deleted Dec 30, 2025
@JamesLMilner JamesLMilner mentioned this pull request Dec 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JamesLMilner