fix/test: more flexible NumericalFilenamePattern matching #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* strings that start with a number are now supported * strings that start end a number are now supported * strings containing numbers that are constant now matched as numbers * add a test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The provided test shows what I'd expect the behavior of the matcher to be, and this differs from the current behavior, especially for strings that start or end with a numerical pattern.
In particular, I have these expectations
[ "0_s", "1_s"]{0}_s[ "0_s", "1_t"]{0}.*[ "0_s0", "1_s0"]{0}_s{1}[ "t0_s0", "t1_s0"]t{0}_s{1}I marked some methods
@Deprecated, these are no longer used and could be deleted (but that would break API).