Test: Add Opencloud E2E Support with Conditional Page Object Selection and CI Integration#110
Merged
anon-pradip merged 2 commits intomainfrom Sep 15, 2025
Merged
Conversation
8223ff8 to
1aa65dd
Compare
saw-jan
reviewed
Sep 1, 2025
0ef0ec0 to
0bdd10a
Compare
0bdd10a to
16b7bc6
Compare
16b7bc6 to
38f083c
Compare
saw-jan
reviewed
Sep 12, 2025
saw-jan
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces support for running end-to-end (E2E) tests against both oCIS and Opencloud deployments. The main changes include:
Files Page Object: Added a new
FilesPage.jsthat handles the case where flow for opening file in presentation viewer is a bit different for two servers (opencloud and owncloud). Here, an extra buttonOpen with...is dynamically selected iftargetServerisopencloud.Conditional Page Object Selection: Updated the step definitions to use
openMDFileInPresentationViewerfrom files page object to open file in presentation viewerConfig Update: The configuration file now reads
TARGET_SERVERfrom the environment, defaulting toocisif not set.CI Workflow Enhancement: The GitHub Actions workflow now includes separate steps for running E2E tests against oCIS and Opencloud, each with the correct environment variable, ensuring the right tests and selectors are used for each deployment.
Documentation: Updated the
READMEwith instructions on how to run E2E tests for both oCIS and Opencloud, clarifying the use of theTARGET_SERVERenvironment variable.Related Issue
Motivation and Context
Previously, the E2E tests only supported oCIS, and selector differences in Opencloud caused failures. By introducing a dedicated page object for Opencloud and selecting it conditionally, we ensure reliable test execution for both platforms. The CI changes guarantee that the correct environment and selectors are used for each server type, improving test coverage and maintainability.
How Has This Been Tested?
Screenshots (if appropriate):
Click on context menu button -> Click on Open with... -> Click on Open in Presentation ViewerTypes of changes
Checklist: