Skip to content

Test: Add Opencloud E2E Support with Conditional Page Object Selection and CI Integration#110

Merged
anon-pradip merged 2 commits intomainfrom
test/make-test-pass-in-opencloud
Sep 15, 2025
Merged

Test: Add Opencloud E2E Support with Conditional Page Object Selection and CI Integration#110
anon-pradip merged 2 commits intomainfrom
test/make-test-pass-in-opencloud

Conversation

@anon-pradip
Copy link
Contributor

@anon-pradip anon-pradip commented Aug 29, 2025

Description

This PR introduces support for running end-to-end (E2E) tests against both oCIS and Opencloud deployments. The main changes include:

  • Files Page Object: Added a new FilesPage.js that handles the case where flow for opening file in presentation viewer is a bit different for two servers (opencloud and owncloud). Here, an extra button Open with... is dynamically selected if targetServer is opencloud.

  • Conditional Page Object Selection: Updated the step definitions to use openMDFileInPresentationViewer from files page object to open file in presentation viewer

  • Config Update: The configuration file now reads TARGET_SERVER from the environment, defaulting to ocis if not set.

  • CI Workflow Enhancement: The GitHub Actions workflow now includes separate steps for running E2E tests against oCIS and Opencloud, each with the correct environment variable, ensuring the right tests and selectors are used for each deployment.

  • Documentation: Updated the README with instructions on how to run E2E tests for both oCIS and Opencloud, clarifying the use of the TARGET_SERVER environment variable.

Related Issue

Motivation and Context

Previously, the E2E tests only supported oCIS, and selector differences in Opencloud caused failures. By introducing a dedicated page object for Opencloud and selecting it conditionally, we ensure reliable test execution for both platforms. The CI changes guarantee that the correct environment and selectors are used for each server type, improving test coverage and maintainability.

How Has This Been Tested?

  • test environment:
  • Locally and CI

Screenshots (if appropriate):

  1. On oCIS: Direct option to open file in presentation viewer after just clicking in context menu
Screenshot from 2025-08-29 10-50-27
  1. On Opencloud: Click on context menu button -> Click on Open with... -> Click on Open in Presentation Viewer
Screenshot from 2025-08-29 12-33-58

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Tests only (no source changes)
  • Documentation only (no source changes)
  • Maintenance (e.g. dependency updates or tooling)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation updated

@anon-pradip anon-pradip force-pushed the test/make-test-pass-in-opencloud branch from 8223ff8 to 1aa65dd Compare August 29, 2025 08:17
@anon-pradip anon-pradip changed the title test: click one more button to view md file in opencloud Test: Add Opencloud E2E Support with Conditional Page Object Selection and CI Integration Aug 29, 2025
@anon-pradip anon-pradip self-assigned this Aug 29, 2025
@anon-pradip anon-pradip requested a review from saw-jan August 29, 2025 08:43
@anon-pradip anon-pradip marked this pull request as ready for review August 29, 2025 08:43
@anon-pradip anon-pradip added the QA label Aug 29, 2025
@anon-pradip anon-pradip force-pushed the test/make-test-pass-in-opencloud branch 2 times, most recently from 0ef0ec0 to 0bdd10a Compare September 2, 2025 07:05
@anon-pradip anon-pradip requested a review from saw-jan September 2, 2025 07:18
@anon-pradip anon-pradip force-pushed the test/make-test-pass-in-opencloud branch from 0bdd10a to 16b7bc6 Compare September 12, 2025 06:07
@anon-pradip anon-pradip force-pushed the test/make-test-pass-in-opencloud branch from 16b7bc6 to 38f083c Compare September 12, 2025 06:15
@anon-pradip anon-pradip merged commit 6db787f into main Sep 15, 2025
2 checks passed
@anon-pradip anon-pradip deleted the test/make-test-pass-in-opencloud branch September 15, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants