make extension work also with OpenCloud#96
Merged
individual-it merged 18 commits intomainfrom Apr 2, 2025
Merged
Conversation
individual-it
force-pushed
the
opencloud
branch
6 times, most recently
from
6c34e3a to
7d77ab8
Compare
Member
Author
|
CC @kulmann in case you are interested to see what I've done here |
saw-jan
reviewed
Apr 1, 2025
README.md
Outdated
| 1. Download the zip file from the [releases page](https://github.com/JankariTech/web-app-presentation-viewer/releases) | ||
|
|
||
| For example: `mdpresentation-viewer-x.x.x.zip` | ||
| For example: `mdpresentation-viewer-<architecture>-x.x.x.zip` |
Member
There was a problem hiding this comment.
will it be arch or server name?
Suggested change
| For example: `mdpresentation-viewer-<architecture>-x.x.x.zip` | |
| For example: `mdpresentation-viewer-<server>-x.x.x.zip` |
Member
Author
There was a problem hiding this comment.
I've renamed it to use server everywhere. What do you think?
Member
There was a problem hiding this comment.
server sounds good. here as well
S-Panta
reviewed
Apr 2, 2025
|
|
||
| env: | ||
| OCIS_URL: https://localhost:9200 | ||
| OC_URL: https://localhost:9200 |
Contributor
There was a problem hiding this comment.
If this is for both, why not keep OCIS_URL as env too?
Member
Author
There was a problem hiding this comment.
because one of the servers is not called OCIS ;-)
saw-jan
reviewed
Apr 2, 2025
Co-authored-by: Sawjan Gurung <saw.jan.grg3e@gmail.com>
saw-jan
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make the extension work with OpenCloud.
It is achieved by
sedto change all imports from owncloud to opencloudMotivation and Context
make it work with OpenCloud without having an other repo
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: