-
-
Notifications
You must be signed in to change notification settings - Fork 0
make extension work also with OpenCloud #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 17 commits
9fb9a29
29ce1be
35ff7b1
e68d7ae
35456a3
db8dcb0
908d0a2
a1b0cd0
3655976
188e6a7
b735af8
ecc4056
bf9eda2
022da3e
8ca2430
9404c1c
23316ea
21c3374
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| node_modules | ||
| dist | ||
| coverage | ||
| pnpm-lock.yaml | ||
|
|
||
| # Editor directories and files | ||
| .vscode | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,12 @@ | ||
| FROM owncloudci/nodejs:20 AS stage | ||
| ARG server=Ocis | ||
|
|
||
| WORKDIR /extension | ||
|
|
||
| COPY . . | ||
| RUN pnpm install | ||
| RUN make install$server | ||
| RUN pnpm build | ||
|
|
||
| FROM alpine:3.20 | ||
| WORKDIR /app | ||
| COPY --from=stage /extension/dist ./ | ||
| COPY --from=stage /extension/dist ./ |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| .PHONY: installOcis installOpencloud dependenciesOcis dependenciesOpencloud install clean package | ||
|
|
||
| installOcis: dependenciesOcis install | ||
|
|
||
| installOpencloud: dependenciesOpencloud install | ||
|
|
||
| dependenciesOcis: clean | ||
| $(MAKE) package PACKAGE_JSON=package-ocis.json | ||
| $(MAKE) depencenciesReplacement SOURCE=opencloud-eu DEST=ownclouders | ||
|
|
||
| dependenciesOpencloud: clean | ||
| $(MAKE) package PACKAGE_JSON=package-opencloud.json | ||
| $(MAKE) depencenciesReplacement SOURCE=ownclouders DEST=opencloud-eu | ||
|
|
||
| package: | ||
| jq -s '.[0] * .[1]' package-common.json $(PACKAGE_JSON) > package.json | ||
|
|
||
| depencenciesReplacement: | ||
| find . -type f \( -name "*.ts" -o -name "*.vue" -o -name "*.prettierrc" \) -not \( -path "./node_modules/*" -o -path "./dist/*" \) -print0 | xargs -0 sed -i 's/${SOURCE}/${DEST}/g' | ||
|
|
||
| clean: | ||
| rm -f package.json | ||
| rm -rf dist | ||
| rm -f pnpm-lock.yaml | ||
|
|
||
| install: | ||
| pnpm install |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -2,7 +2,7 @@ | |||||
|
|
||||||
|  | ||||||
|
|
||||||
| A markdown presentation viewer for [ownCloud web](https://github.com/owncloud/web/) (the webUI of [oCIS](https://github.com/owncloud/ocis/)) using the [reveal.js](https://revealjs.com/) library. | ||||||
| A markdown presentation viewer for [OpenCloud](https://github.com/opencloud-eu/opencloud/) and [oCIS](https://github.com/owncloud/ocis/) using the [reveal.js](https://revealjs.com/) library. | ||||||
|
|
||||||
| It allows users to: | ||||||
|
|
||||||
|
|
@@ -11,42 +11,35 @@ It allows users to: | |||||
|
|
||||||
| ## Demonstration | ||||||
|
|
||||||
| - [Demonstation page](https://ocis.in-nepal.de/com.github.jankaritech.mdpresentation-viewer/public/phDIUqntYOMSfcE/presentation.md) | ||||||
| - [Demonstation page OpenCloud](https://opencloud.in-nepal.de/files/link/public/PHxkrAlpSRaqNNK) | ||||||
| - [Demonstation page oCIS](https://ocis.in-nepal.de/files/link/public/phDIUqntYOMSfcE) | ||||||
| - Click on `Open in Presentation Viewer` to view the slides | ||||||
|
|
||||||
| ## Supported oCIS and Web Versions | ||||||
|
|
||||||
| - [oCIS](https://github.com/owncloud/ocis) (>= 6.x.x) | ||||||
| - [Web](https://nodejs.org/en/) (>= 9.x.x) | ||||||
| - [oCIS](https://github.com/owncloud/ocis) (>= 6.x.x) or [OpenCloud](https://github.com/opencloud-eu/opencloud/) (>= 2.0.0) | ||||||
|
|
||||||
| ## App Installation | ||||||
|
|
||||||
| > NOTE: Requires oCIS >= 6.0.0 | ||||||
|
|
||||||
| 1. Download the zip file from the [releases page](https://github.com/JankariTech/web-app-presentation-viewer/releases) | ||||||
|
|
||||||
| For example: `mdpresentation-viewer-x.x.x.zip` | ||||||
| For example: `mdpresentation-viewer-<architecture>-x.x.x.zip` | ||||||
|
||||||
| For example: `mdpresentation-viewer-<architecture>-x.x.x.zip` | |
| For example: `mdpresentation-viewer-<server>-x.x.x.zip` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've renamed it to use server everywhere. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
server sounds good. here as well
individual-it marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| --- | ||
| services: | ||
| opencloud: | ||
| depends_on: | ||
| mdpresentation-viewer: | ||
| condition: service_completed_successfully | ||
|
|
||
| mdpresentation-viewer: | ||
| image: jankaritech/mdpresentation-viewer-opencloud:2.1.0 | ||
| volumes: | ||
| - opencloud-apps:/apps | ||
| entrypoint: | ||
| - /bin/sh | ||
| command: ["-c", "cp -R /app/* /apps"] |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| services: | ||
| opencloud: | ||
| image: opencloudeu/opencloud-rolling:${OC_IMAGE_TAG:-latest} | ||
| entrypoint: /bin/sh | ||
| command: ['-c', 'opencloud init || true && opencloud server'] | ||
| ports: | ||
| - 9200:9200 | ||
| environment: | ||
| OC_URL: https://localhost:9200 | ||
| OC_INSECURE: true | ||
| OC_LOG_LEVEL: error | ||
| # WEB | ||
| WEB_ASSET_APPS_PATH: /web/apps | ||
| # IDM | ||
| IDM_CREATE_DEMO_USERS: true | ||
| IDM_ADMIN_PASSWORD: admin | ||
| # PROXY | ||
| PROXY_ENABLE_BASIC_AUTH: true | ||
| PROXY_CSP_CONFIG_FILE_LOCATION: /etc/opencloud/csp.yml | ||
| volumes: | ||
| - ./dist:/web/apps:ro | ||
| - ./dev/config/csp.yml:/etc/opencloud/csp.yml |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "devDependencies": { | ||
| "@ownclouders/extension-sdk": "^11.3.1", | ||
| "@ownclouders/prettier-config": "0.0.1" | ||
| }, | ||
| "peerDependencies": { | ||
| "@ownclouders/web-client": "^11.3.1", | ||
| "@ownclouders/web-pkg": "^11.3.1" | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "devDependencies": { | ||
| "@opencloud-eu/extension-sdk": "^1.0.0", | ||
| "@opencloud-eu/prettier-config": "^1.0.0" | ||
| }, | ||
| "peerDependencies": { | ||
| "@opencloud-eu/web-client": "^1.0.0", | ||
| "@opencloud-eu/web-pkg": "^1.0.0" | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is for both, why not keep
OCIS_URLas env too?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OC_URLserves for bothThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because one of the servers is not called
OCIS;-)