fix: remove scope-manager dependency#379
Merged
JasonWeinzierl merged 1 commit intomainfrom Feb 16, 2026
Merged
Conversation
JasonWeinzierl
force-pushed
the
no-scope-dep
branch
from
f8ff173 to
e98144f
Compare
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
JasonWeinzierl
force-pushed
the
no-scope-dep
branch
from
e98144f to
e5a3258
Compare
JasonWeinzierl
force-pushed
the
no-scope-dep
branch
from
e5a3258 to
b9c1135
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scope-manager is still a transitive dependency via utils. But this change lets us explicitly remove it.
Only one rule uses the
isImportutility, which is unique compared to every other rule. It should be fine to just check iftakeWhileis getting called from within apipefunction and assume it's RxJS.