Open
Conversation
Draft
ec085d8 to
e7a4b00
Compare
e7a4b00 to
5a610ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates how we specify the name type. Before there was a string property
mangledTypeonSymbolicName. This property describes what kind of entity the name refers to e.g. getter, property, function, type.This strings should be duplicate free but they are distributed in many files. To have a better overview on the used strings a sealed class
NameTypewas introduced which collects all the name types.The changes in the resulting viper program can be categorized into:
TF$T$Unitwhich was changed tot$F$t$Unit. Basically the upper caseTwas replaced with a lowercase to match the other type names. Also it was separated using$.try_exittotryExitarg1toarg$1ginstead ofpgpredinstead ofpparinstead ofpNote: The
NameTypeSpecialwill be removed in a future PR. It makes sense to remove it, once we got rid off theSpecialName. RemovingSpecialNamerequires a larger reconstruction.