Draft
Conversation
The-Ray-Man
force-pushed
the
ramon/name-registration
branch
from
e17ee99 to
cb7ed0e
Compare
The-Ray-Man
force-pushed
the
ramon/name-registration
branch
from
cb7ed0e to
8714b13
Compare
The-Ray-Man
force-pushed
the
ramon/name-registration
branch
from
8714b13 to
16dd6f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should not be merged before #100
Previously, not all names appearing in the program were registered with the resolver. This was not an issue for the
SimpleResolverbecause it operates independently of registered names. However, future resolver implementations will require every name to be registered, and this PR prepares the codebase for that requirement.Some registration passes included here may be redundant. For example, when registering a while loop, the process also traverses the condition. It is generally impossible for a condition to contain a fresh name, making that specific pass unnecessary.
I suggest retaining these passes regardless. The computational overhead is minimal, and keeping them ensures a more robust guarantee that all names are registered without exception.