Skip to content

Conversation

@ApoloApps
Copy link

@ApoloApps ApoloApps commented Dec 16, 2025

Changes the SkiaBackedCanvas to internally use more optimized functions based on this Skiko PR
It also includes minimal changes like:

  1. Micro optimizations for DefaultOpenContextMenu to use non iterator-allocator functions
  2. Update Modifier.drawSelectionHandle to not use Composed Api
  3. Changed BasicContextMenu's onClose to use method reference

Testing

N/A

Release Notes

N/A

@ApoloApps
Copy link
Author

@MatkovIvan would be nice to have it before Xmas holidays :)

@MatkovIvan MatkovIvan self-requested a review January 28, 2026 15:15
@MatkovIvan MatkovIvan requested a review from igordmn January 28, 2026 15:16
Copy link
Member

@MatkovIvan MatkovIvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures are legitimate, please fix them to proceed

@ApoloApps
Copy link
Author

Test failures are legitimate, please fix them to proceed

should work now! Cause: logic error on drawImageRect&Co

@ApoloApps
Copy link
Author

In the previous run,


fails, but in my computer it passes.
image

@ApoloApps ApoloApps requested a review from MatkovIvan January 28, 2026 21:20
@MatkovIvan MatkovIvan merged commit 9244c20 into JetBrains:jb-main Jan 28, 2026
17 checks passed
@ApoloApps ApoloApps deleted the moreOptimizations branch January 29, 2026 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants