Canvas Extension functions not to allocate intermediate objects #1137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all (on the Ui Toolkit side e.g. Compose Ui)
MatkovIvan
approved these changes
Dec 10, 2025
igordmn
approved these changes
Dec 10, 2025
This was referenced Dec 16, 2025
Contributor
Author
|
Part 2 of this PR: #1140 |
igordmn
pushed a commit
that referenced
this pull request
Jan 28, 2026
This is part 2 of [this pr](#1137) **What has changed?** 1. Added more extension functions that prevent intermediate object allocations from a lot of the Skiko api surface 2. Migrated EnumClass.values() to entries in a lot of classes (maybe some have been missed) **Next** Try (important keyword here :), cause if not wrong there are Skia and Compose diffs on how they're treated) doing less copies of Matrix ## Release Notes Added API that can accept primitive values instead of `Rect`, `RRect`, `Offset` to avoid additional object allocation
MatkovIvan
pushed a commit
to JetBrains/compose-multiplatform-core
that referenced
this pull request
Jan 28, 2026
Changes the SkiaBackedCanvas to internally use more optimized functions based [on this Skiko PR](JetBrains/skiko#1137) It also includes minimal changes like: 1. [Micro optimizations for DefaultOpenContextMenu to use non iterator-allocator functions](577e1b1) 2. [Update Modifier.drawSelectionHandle to not use Composed Api](1cc7182) 3. [Changed BasicContextMenu's onClose to use method reference](b7d3bac) ## Testing N/A ## Release Notes N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some functions to Skia canvas to be able to avoid creating intermediate objects (SkRect, SkRRect, etc) on some hot paths.
See this conversation for the context of the PR.
This is the first step to allow for Compose Ui SkiaBackedCanvas to avoid unnecessary intermediate allocations:
among others.
Next steps
-> open pr in Compose Ui to use these more optimized functions
-> More optimizations on the Skiko side, Matrixes is a good example, CMP and Skiko are processing Matrixes 2 times, toSkiaMatrix, which basically is the same as a wrapper around FloatArray and then in the toInterop method which copies the array (unavoidable). A good optimization would be to just pass the Compose Matrix underlying
valuesproperty which is a FloatArray that toInterop accepts and so a lot of intermediate objects and transformations could be avoided altogether